chore!: Delete unused code in feature view#3016
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3016 +/- ##
===========================================
- Coverage 77.59% 59.35% -18.25%
===========================================
Files 194 194
Lines 16267 16094 -173
===========================================
- Hits 12622 9552 -3070
- Misses 3645 6542 +2897
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
achals
left a comment
There was a problem hiding this comment.
Is this still a WIP PR? Looks pretty good to me.
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
… odfv Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
511b14c to
f43e096
Compare
| this group of features lives forever. Note that large ttl's or a ttl of 0 | ||
| can result in extremely computationally intensive queries. | ||
| batch_source (optional): The batch source of data where this group of features | ||
| batch_source: The batch source of data where this group of features |
There was a problem hiding this comment.
huh did you do this in reverse? the docs suggest we want source instead of batch_source vs stream_source
There was a problem hiding this comment.
oh these are attributes. Maybe remove the two lines on "deprecated in favor of source"
There was a problem hiding this comment.
@adchia the __init__ takes in source as a parameter; it then sets batch_source and stream_source as attributes
There was a problem hiding this comment.
yep. just remove the two lines here saying "This is deprecated in favor of source" ?
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adchia, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
BREAKING CHANGE: Deprecate feature view parameters such as
batch_sourceandstream_sourceand deprecate the option to use positional arguments