Skip to content

chore: Remove old way of flagging features as experimental #3005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 5 commits into from
Aug 4, 2022
Merged

chore: Remove old way of flagging features as experimental #3005

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5dfc8e1
remove straggler references
adchia Aug 3, 2022
3abed13
remove straggler references
adchia Aug 3, 2022
1b9a52d
fix
adchia Aug 3, 2022
2e559ea
rebase
adchia Aug 4, 2022
3dfcd43
add lambda doc to feature server README
adchia Aug 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rebase 
Signed-off-by: Danny Chiao <danny@tecton.ai>
  • Loading branch information
@adchia
adchia committed Aug 4, 2022
commit 2e559eababfaa877b8fa5897964abd9492b2173f
9 changes: 0 additions & 9 deletions docs/reference/feature-servers/alpha-aws-lambda-feature-server.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,21 +34,12 @@ If enabled, the feature server will be deployed during `feast apply`. After it i

Feast requires the following permissions in order to deploy and teardown AWS Lambda feature server:

<<<<<<< HEAD:docs/reference/feature-servers/alpha-aws-lambda-feature-server.md
| Permissions | Resources |
| --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| <p>lambda:CreateFunction</p><p>lambda:GetFunction</p><p>lambda:DeleteFunction</p><p>lambda:AddPermission</p><p>lambda:UpdateFunctionConfiguration</p> | arn:aws:lambda:\<region>:\<account\_id>:function:feast-\* |
| <p>ecr:CreateRepository</p><p>ecr:DescribeRepositories</p><p>ecr:DeleteRepository</p><p>ecr:PutImage</p><p>ecr:DescribeImages</p><p>ecr:BatchDeleteImage</p><p>ecr:CompleteLayerUpload</p><p>ecr:UploadLayerPart</p><p>ecr:InitiateLayerUpload</p><p>ecr:BatchCheckLayerAvailability</p><p>ecr:GetDownloadUrlForLayer</p><p>ecr:GetRepositoryPolicy</p><p>ecr:SetRepositoryPolicy</p><p>ecr:GetAuthorizationToken</p> | \* |
| iam:PassRole | arn:aws:iam::\<account\_id>:role/ |
| apigateway:\* | <p>arn:aws:apigateway:<em>::/apis/</em>/routes/<em>/routeresponses</em></p><p><em>arn:aws:apigateway:</em>::/apis/<em>/routes/</em>/routeresponses/</p><p><em>arn:aws:apigateway:</em>::/apis/<em>/routes/</em></p><p>arn:aws:apigateway:<em>::/apis/</em>/routes</p><p>arn:aws:apigateway:<em>::/apis/</em>/integrations</p><p>arn:aws:apigateway:<em>::/apis/</em>/stages/<em>/routesettings/</em></p><p>arn:aws:apigateway:<em>::/apis/</em></p><p>arn:aws:apigateway:*::/apis</p> |
=======
| Permissions | Resources |
| --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ |
| <p>lambda:CreateFunction</p><p>lambda:GetFunction</p><p>lambda:DeleteFunction</p><p>lambda:AddPermission</p><p>lambda:UpdateFunctionConfiguration</p> | arn:aws:lambda:\<region>:\<account_id>:function:feast-\* |
| <p>ecr:CreateRepository</p><p>ecr:DescribeRepositories</p><p>ecr:DeleteRepository</p><p>ecr:PutImage</p><p>ecr:DescribeImages</p><p>ecr:BatchDeleteImage</p><p>ecr:CompleteLayerUpload</p><p>ecr:UploadLayerPart</p><p>ecr:InitiateLayerUpload</p><p>ecr:BatchCheckLayerAvailability</p><p>ecr:GetDownloadUrlForLayer</p><p>ecr:GetRepositoryPolicy</p><p>ecr:SetRepositoryPolicy</p><p>ecr:GetAuthorizationToken</p> | \* |
| <p>iam:PassRole</p> | arn:aws:iam::\<account_id>:role/<lambda-execution-role-name> |
| <p>apigateway:*</p> | <p>arn:aws:apigateway:*::/apis/*/routes/*/routeresponses</p><p>arn:aws:apigateway:*::/apis/*/routes/*/routeresponses/*</p><p>arn:aws:apigateway:*::/apis/*/routes/*</p><p>arn:aws:apigateway:*::/apis/*/routes</p><p>arn:aws:apigateway:*::/apis/*/integrations</p><p>arn:aws:apigateway:*::/apis/*/stages/*/routesettings/*</p><p>arn:aws:apigateway:*::/apis/*</p><p>arn:aws:apigateway:*::/apis</p> |
>>>>>>> 6079e443a (remove straggler references):docs/reference/alpha-aws-lambda-feature-server.md

The following inline policy can be used to grant Feast the necessary permissions:

Expand Down