allow empty string to select a NoOp write transform - #30
Conversation
|
Is it possible to rather have an option to turn off a store type instead of having empty strings? |
|
Yes there is. If there is a storage spec that specifies type = "noop" you can use it's store id. |
I mean an option within the feature specification like and then omitting the actual store from the spec. |
Can we have this as separate issue? |
|
/retest |
Done #38
You need to rebase first @pradithya . You dont have a Makefile in the root of the repo with a |
|
rebased against master /retest |
|
/retest |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tims The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…istry Store and Manage permissions in the Registry
This is for #5 .
Note this also allows core to return no warehouse store id and/or no serving store id in the feature specs. Either one, will be replaced with a NoOp.