Skip to content

Empty response handling in serving api #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pradithya merged 1 commit into from
Dec 13, 2018
+0 −8
Merged

Empty response handling in serving api #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Avoid returning error to caller when the query is successful but retu… 
…rns empty result.
  • Loading branch information
Pradithya Aria committed Dec 12, 2018
commit ee7fd87d94697e9e23bf971ecf0a3977ff0ba6f9
8 changes: 0 additions & 8 deletions serving/src/main/java/feast/serving/grpc/ServingGrpcService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,14 +77,6 @@ public void queryFeatures(Request request, StreamObserver<Response> responseObse
Request validRequest = checkTimestampRange(request);
Response response = feast.queryFeatures(validRequest);

if (response.getEntitiesCount() < 1) {
responseObserver.onError(
new StatusRuntimeException(
Status.fromCode(NOT_FOUND)
.withDescription("No value is found for the requested feature")));
return;
}

innerSpan.log("calling onNext");
responseObserver.onNext(response);
innerSpan.log("calling onCompleted");
Expand Down