Skip to content

fix: Fix file offline store logic for feature views without ttl #2971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 2 commits into from
Jul 26, 2022
Merged

fix: Fix file offline store logic for feature views without ttl #2971

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f243ef
Add new test for historical retrieval with feature views with no ttl
felixwang9817 Jul 26, 2022
c6536e7
Fix no ttl logic
felixwang9817 Jul 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix no ttl logic 
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
  • Loading branch information
@felixwang9817
felixwang9817 committed Jul 26, 2022
commit c6536e7eb90f16eac428a95fbc35d91357ec58f7
8 changes: 8 additions & 0 deletions sdk/python/feast/infra/offline_stores/file.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,6 +635,14 @@ def _filter_ttl(
)
]

df_to_join = df_to_join.persist()
else:
df_to_join = df_to_join[
# do not drop entity rows if one of the sources returns NaNs
df_to_join[timestamp_field].isna()
| (df_to_join[timestamp_field] <= df_to_join[entity_df_event_timestamp_col])
]

df_to_join = df_to_join.persist()

return df_to_join
Expand Down