Skip to content

Fix bug in core not setting default Kafka source - #297

Merged
woop merged 2 commits into
feast-dev:0.3-devfrom
woop:0.3-dev
Nov 8, 2019
Merged

Fix bug in core not setting default Kafka source#297
woop merged 2 commits into
feast-dev:0.3-devfrom
woop:0.3-dev

Conversation

@woop

@woop woop commented Nov 8, 2019

Copy link
Copy Markdown
Member

No description provided.

@feast-ci-bot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop

woop commented Nov 8, 2019

Copy link
Copy Markdown
Member Author

/lgtm

@feast-ci-bot

Copy link
Copy Markdown
Collaborator

@woop: you cannot LGTM your own PR.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@woop woop added the lgtm label Nov 8, 2019
@woop
woop merged commit 10db343 into feast-dev:0.3-dev Nov 8, 2019
Srihari1192 pushed a commit to Srihari1192/feast that referenced this pull request Apr 21, 2026
Point feast-group-test and feast-nightly-test pipelineRef to
Srihari1192/odh-konflux-central#fix-go-its-version to validate the
go-toolset:1.24 upgrade before merging odh-konflux-central PR feast-dev#297.

Revert after PR feast-dev#297 is merged.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants