Skip to content

docs: Add docs for batch materialization engine#2959

Merged
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
achals:achal/engine-docs
Jul 20, 2022
Merged

docs: Add docs for batch materialization engine#2959
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
achals:achal/engine-docs

Conversation

@achals
Copy link
Copy Markdown
Member

@achals achals commented Jul 20, 2022

Signed-off-by: Achal Shah achals@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

@achals
docs: Add docs for batch materialization engine
0b8a28f 
Signed-off-by: Achal Shah <achals@gmail.com>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 20, 2022 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.68%. Comparing base (d0d27a3) to head (0b8a28f).
⚠️ Report is 1780 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2959   +/-   ##
=======================================
  Coverage   77.67%   77.68%           
=======================================
  Files         186      186           
  Lines       16339    16339           
=======================================
+ Hits        12692    12693    +1     
+ Misses       3647     3646    -1
Flag Coverage Δ
integrationtests 68.67% <100.00%> (+<0.01%) ⬆️
unittests 58.51% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

felixwang9817
felixwang9817 approved these changes Jul 20, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

feast-ci-bot commented Jul 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit a965af9 into feast-dev:master Jul 20, 2022
@achals achals deleted the achal/engine-docs branch July 21, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@felixwang9817 felixwang9817 felixwang9817 approved these changes

Assignees

@felixwang9817 felixwang9817

Labels

approved lgtm size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@achals @codecov-commenter @feast-ci-bot @felixwang9817