Skip to content

fix: Version entity serialization mechanism and fix issue with int64 vals #2944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 19 commits into from
Jul 20, 2022
Merged

fix: Version entity serialization mechanism and fix issue with int64 vals #2944

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
af4ccef
fix: version the entity serialization mechanism to fix issue with int…
achals Jun 29, 2022
c6dabd1
fix tests
achals Jul 15, 2022
b709511
Add a test
achals Jul 15, 2022
0b81975
Add a test
achals Jul 15, 2022
b91bf17
fix test
achals Jul 15, 2022
4bc7c80
fix test
achals Jul 15, 2022
13712bb
fix test
achals Jul 15, 2022
de47286
simplify
achals Jul 15, 2022
3aac0f6
simplify
achals Jul 16, 2022
da9b407
feature_store.yaml
achals Jul 18, 2022
7ab893c
fix tests
achals Jul 18, 2022
2e1b123
remove protos
achals Jul 18, 2022
fd1e8eb
fix tests
achals Jul 18, 2022
ec4a099
update feature_store.yaml templates
achals Jul 18, 2022
37e32e4
fix java
achals Jul 18, 2022
e1a47fc
fix java test
achals Jul 18, 2022
bbceb68
docs
achals Jul 19, 2022
4aa2ba7
docs
achals Jul 19, 2022
82259d4
docs
achals Jul 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix tests 
Signed-off-by: Achal Shah <achals@gmail.com>
  • Loading branch information
@achals
achals committed Jul 19, 2022
commit c6dabd163a00ae0693c3b5c6e6bedc1550edbff7
8 changes: 4 additions & 4 deletions sdk/python/feast/infra/key_encoding_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,11 @@ def _serialize_val(
return struct.pack("<i", v.int32_val), ValueType.INT32
elif value_type == "int64_val":
if (
entity_key_serialization_version >= 0
and entity_key_serialization_version <= 1
entity_key_serialization_version >= 0
and entity_key_serialization_version <= 1
):
return struct.pack("<q", v.int64_val), ValueType.INT64
return struct.pack("<l", v.int64_val), ValueType.INT64
return struct.pack("<l", v.int64_val), ValueType.INT64
Comment thread
achals marked this conversation as resolved.
Outdated
return struct.pack("<q", v.int64_val), ValueType.INT64
else:
raise ValueError(f"Value type not supported for Firestore: {v}")

Expand Down