Fix

Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
feast-dev · feast-ci-bot · Jul 14, 2022 · Jul 12, 2022 · Jul 12, 2022 · Jul 14, 2022
commit 37b4a972d957c8ba01ab446ef45cd59be29f8f5a
diff --git a/.github/workflows/nightly-ci.yml b/.github/workflows/nightly-ci.yml
@@ -23,9 +23,69 @@ jobs:
         name: Check if there were commits in the last day
         if: ${{ github.event_name == 'schedule' }}
         run: echo '::set-output name=WAS_EDITED::'$(test -n "$(git log --format=%H --since='24 hours ago')" && echo 'true' || echo 'false')
-
+  # build-docker-image:
+  #   # all jobs MUST have this if check for 'ok-to-test' or 'approved' for security purposes.
+  #   if:
+  #     (github.event.action == 'labeled' && (github.event.label.name == 'approved' || github.event.label.name == 'lgtm' || github.event.label.name == 'ok-to-test')) ||
+  #     (github.event.action != 'labeled' && (contains(github.event.pull_request.labels.*.name, 'ok-to-test') || contains(github.event.pull_request.labels.*.name, 'approved') || contains(github.event.pull_request.labels.*.name, 'lgtm')))
+  #   runs-on: ubuntu-latest
+  #   steps:
+  #     - uses: actions/checkout@v3
+  #       with:
+  #         # pull_request_target runs the workflow in the context of the base repo
+  #         # as such actions/checkout needs to be explicit configured to retrieve
+  #         # code from the PR.
+  #         ref: refs/pull/${{ github.event.pull_request.number }}/merge
+  #         submodules: recursive
+  #     - name: Set up QEMU
+  #       uses: docker/setup-qemu-action@v1
+  #     - name: Set up Docker Buildx
+  #       uses: docker/setup-buildx-action@v2
+  #       with:
+  #         install: true
+  #     - name: Set up AWS SDK
+  #       uses: aws-actions/configure-aws-credentials@v1
+  #       with:
+  #         aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
+  #         aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
+  #         aws-region: us-west-2
+  #     - name: Login to Amazon ECR
+  #       id: login-ecr
+  #       uses: aws-actions/amazon-ecr-login@v1
+  #     - name: Set ECR image tag
+  #       id: image-tag
+  #       run: echo "::set-output name=DOCKER_IMAGE_TAG::`git rev-parse HEAD`"
+  #     - name: Cache Public ECR Image
+  #       id: lambda_python_3_9
+  #       uses: actions/cache@v2
+  #       with:
+  #         path: ~/cache
+  #         key: lambda_python_3_9
+  #     - name: Handle Cache Miss (pull public ECR image & save it to tar file)
+  #       if: steps.cache-primes.outputs.cache-hit != 'true'
+  #       run: |
+  #         mkdir -p ~/cache
+  #         docker pull public.ecr.aws/lambda/python:3.9
+  #         docker save public.ecr.aws/lambda/python:3.9 -o ~/cache/lambda_python_3_9.tar
+  #     - name: Handle Cache Hit (load docker image from tar file)
+  #       if: steps.cache-primes.outputs.cache-hit == 'true'
+  #       run: |
+  #         docker load -i ~/cache/lambda_python_3_9.tar
+  #     - name: Build and push
+  #       env:
+  #         ECR_REGISTRY: ${{ steps.login-ecr.outputs.registry }}
+  #         ECR_REPOSITORY: feast-python-server
+  #       run: |
+  #         docker build \
+  #           --file sdk/python/feast/infra/feature_servers/aws_lambda/Dockerfile \
+  #           --tag $ECR_REGISTRY/$ECR_REPOSITORY:${{ steps.image-tag.outputs.DOCKER_IMAGE_TAG }} \
+  #           --load \
+  #           .
+  #         docker push $ECR_REGISTRY/$ECR_REPOSITORY:${{ steps.image-tag.outputs.DOCKER_IMAGE_TAG }}
+  #   outputs:
+  #     DOCKER_IMAGE_TAG: ${{ steps.image-tag.outputs.DOCKER_IMAGE_TAG }}
   integration-test-python:
-    needs: check_date
+    needs: [check_date, build-docker-image]
     runs-on: ${{ matrix.os }}
     strategy:
       fail-fast: false
@@ -57,7 +117,7 @@ jobs:
         uses: actions/setup-python@v2
         id: setup-python
         with:
-          python-version: ${{ os.PYTHON }}
+          python-version: ${{ matrix.python-version }}
           architecture: x64
       - name: Setup Go
         id: setup-go