Skip to content

chore: Add project metadata to registry#2938

Merged
feast-ci-bot merged 16 commits into
feast-dev:masterfrom
adchia:projectMetadata
Jul 18, 2022
Merged

chore: Add project metadata to registry#2938
feast-ci-bot merged 16 commits into
feast-dev:masterfrom
adchia:projectMetadata

Conversation

@adchia

@adchia adchia commented Jul 13, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:
Initial scaffolding of storing project level metadata in the registry

Which issue(s) this PR fixes:

Fixes #

@codecov-commenter

codecov-commenter commented Jul 14, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2938 (e830f1e) into master (476fccd) will increase coverage by 0.04%.
The diff coverage is 89.63%.

@@            Coverage Diff             @@
##           master    #2938      +/-   ##
==========================================
+ Coverage   78.56%   78.61%   +0.04%     
==========================================
  Files         183      184       +1     
  Lines       16168    16305     +137     
==========================================
+ Hits        12703    12818     +115     
- Misses       3465     3487      +22
Flag Coverage Δ
integrationtests 68.66% <67.35%> (-0.18%) ⬇️
unittests 59.42% <79.27%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/driver_test_data.py 100.00% <ø> (ø)
sdk/python/feast/project_metadata.py 73.52% <73.52%> (ø)
sdk/python/feast/registry.py 83.05% <87.50%> (+0.32%) ⬆️
sdk/python/feast/infra/registry_stores/sql.py 73.37% <97.36%> (+3.22%) ⬆️
sdk/python/feast/feature_store.py 85.84% <100.00%> (ø)
sdk/python/feast/usage.py 91.53% <100.00%> (+0.09%) ⬆️
...ts/integration/feature_repos/repo_configuration.py 86.28% <100.00%> (ø)
...on/tests/integration/registration/test_registry.py 95.34% <100.00%> (+0.26%) ⬆️
...ests/integration/registration/test_sql_registry.py 93.95% <100.00%> (+0.42%) ⬆️
sdk/python/tests/utils/online_read_write_test.py 93.54% <0.00%> (-6.46%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 476fccd...e830f1e. Read the comment docs.

@adchia adchia marked this pull request as ready for review July 14, 2022 19:22
@achals achals self-assigned this Jul 15, 2022
achals
achals approved these changes Jul 18, 2022
View reviewed changes

@achals achals left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Comment thread sdk/python/feast/infra/registry_stores/sql.py Outdated
adchia added 12 commits July 18, 2022 15:05
@adchia
chore: Add project metadata to registry
b987ad6 
Signed-off-by: Danny Chiao <danny@tecton.ai>
@adchia
lint
f53eeba 
Signed-off-by: Danny Chiao <danny@tecton.ai>
@adchia
add to file registry
2d0e357 
Signed-off-by: Danny Chiao <danny@tecton.ai>
@adchia
add to sql registry
ee3754b 
Signed-off-by: Danny Chiao <danny@tecton.ai>
@adchia
fixes
3a4924b 
Signed-off-by: Danny Chiao <danny@tecton.ai>
@adchia
fixes
90366eb 
Signed-off-by: Danny Chiao <danny@tecton.ai>
@adchia
fixes
3e3f157 
Signed-off-by: Danny Chiao <danny@tecton.ai>
@adchia
fix
27934e2 
Signed-off-by: Danny Chiao <danny@tecton.ai>
@adchia
lint
8ca1e69 
Signed-off-by: Danny Chiao <danny@tecton.ai>
@adchia
fix test
4106259 
Signed-off-by: Danny Chiao <danny@tecton.ai>
@adchia
add tests
4be06d6 
Signed-off-by: Danny Chiao <danny@tecton.ai>
@adchia
make backwards compatible
ed23ff1 
Signed-off-by: Danny Chiao <danny@tecton.ai>
@adchia adchia force-pushed the projectMetadata branch from 4b23e19 to ed23ff1 Compare July 18, 2022 19:13
@feast-ci-bot feast-ci-bot removed the lgtm label Jul 18, 2022
adchia added 2 commits July 18, 2022 15:16
@adchia
update makefile for passing local tests
c5f2937 
Signed-off-by: Danny Chiao <danny@tecton.ai>
@adchia
update makefile for passing local tests
c2745f5 
Signed-off-by: Danny Chiao <danny@tecton.ai>
adchia added 2 commits July 18, 2022 15:22
@adchia
update makefile for passing local tests
46d9e97 
Signed-off-by: Danny Chiao <danny@tecton.ai>
@adchia
update makefile for passing local tests
e830f1e 
Signed-off-by: Danny Chiao <danny@tecton.ai>
achals
achals approved these changes Jul 18, 2022
View reviewed changes

@achals achals left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot

feast-ci-bot commented Jul 18, 2022

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit d593351 into feast-dev:master Jul 18, 2022
kevjumba pushed a commit that referenced this pull request Jul 18, 2022
@adchia @kevjumba
chore: Add project metadata to registry (#2938)
0d9b1d9 
* chore: Add project metadata to registry

Signed-off-by: Danny Chiao <danny@tecton.ai>

* lint

Signed-off-by: Danny Chiao <danny@tecton.ai>

* add to file registry

Signed-off-by: Danny Chiao <danny@tecton.ai>

* add to sql registry

Signed-off-by: Danny Chiao <danny@tecton.ai>

* fixes

Signed-off-by: Danny Chiao <danny@tecton.ai>

* fixes

Signed-off-by: Danny Chiao <danny@tecton.ai>

* fixes

Signed-off-by: Danny Chiao <danny@tecton.ai>

* fix

Signed-off-by: Danny Chiao <danny@tecton.ai>

* lint

Signed-off-by: Danny Chiao <danny@tecton.ai>

* fix test

Signed-off-by: Danny Chiao <danny@tecton.ai>

* add tests

Signed-off-by: Danny Chiao <danny@tecton.ai>

* make backwards compatible

Signed-off-by: Danny Chiao <danny@tecton.ai>

* update makefile for passing local tests

Signed-off-by: Danny Chiao <danny@tecton.ai>

* update makefile for passing local tests

Signed-off-by: Danny Chiao <danny@tecton.ai>

* update makefile for passing local tests

Signed-off-by: Danny Chiao <danny@tecton.ai>

* update makefile for passing local tests

Signed-off-by: Danny Chiao <danny@tecton.ai>
kevjumba pushed a commit that referenced this pull request Jul 19, 2022
@adchia @kevjumba
chore: Add project metadata to registry (#2938)
f341703 
* chore: Add project metadata to registry

Signed-off-by: Danny Chiao <danny@tecton.ai>

* lint

Signed-off-by: Danny Chiao <danny@tecton.ai>

* add to file registry

Signed-off-by: Danny Chiao <danny@tecton.ai>

* add to sql registry

Signed-off-by: Danny Chiao <danny@tecton.ai>

* fixes

Signed-off-by: Danny Chiao <danny@tecton.ai>

* fixes

Signed-off-by: Danny Chiao <danny@tecton.ai>

* fixes

Signed-off-by: Danny Chiao <danny@tecton.ai>

* fix

Signed-off-by: Danny Chiao <danny@tecton.ai>

* lint

Signed-off-by: Danny Chiao <danny@tecton.ai>

* fix test

Signed-off-by: Danny Chiao <danny@tecton.ai>

* add tests

Signed-off-by: Danny Chiao <danny@tecton.ai>

* make backwards compatible

Signed-off-by: Danny Chiao <danny@tecton.ai>

* update makefile for passing local tests

Signed-off-by: Danny Chiao <danny@tecton.ai>

* update makefile for passing local tests

Signed-off-by: Danny Chiao <danny@tecton.ai>

* update makefile for passing local tests

Signed-off-by: Danny Chiao <danny@tecton.ai>

* update makefile for passing local tests

Signed-off-by: Danny Chiao <danny@tecton.ai>
@adchia adchia deleted the projectMetadata branch July 21, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@achals achals achals approved these changes

Assignees

@achals achals

Labels

approved lgtm size/XL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@adchia @codecov-commenter @feast-ci-bot @achals