Skip to content

chore: Fixes and Readme for python<>go interface #2936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 10 commits into from
Jul 15, 2022
Merged

chore: Fixes and Readme for python<>go interface #2936

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a5e270d
chore: Fixes and Readme for python<>go interface
achals Jul 13, 2022
492dc91
cr
achals Jul 13, 2022
f205e41
Switch to cgo allocator
felixwang9817 Jul 13, 2022
ae71efa
Fix memory leak
felixwang9817 Jul 13, 2022
a6232d9
Fix another memory leak
felixwang9817 Jul 13, 2022
b0283ed
Do not use cgo allocator for memory buffers
felixwang9817 Jul 14, 2022
9951db9
Switch to cgo allocator for memory buffers
felixwang9817 Jul 14, 2022
656cb40
Switch test to pass
felixwang9817 Jul 14, 2022
9c0b757
Use more idiomatic way to test truth
felixwang9817 Jul 14, 2022
78b046d
Update docs
felixwang9817 Jul 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix memory leak 
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
  • Loading branch information
@felixwang9817
felixwang9817 committed Jul 13, 2022
commit ae71efa50aedb4e5b6b8513e9cd705fe27430afc
30 changes: 30 additions & 0 deletions go/embedded/online_features.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,11 @@ type OnlineFeatureService struct {
grpcStopCh chan os.Signal
httpStopCh chan os.Signal

statusColumnBuildersToRelease []*array.Int32Builder
tsColumnBuildersToRelease []*array.Int64Builder
arraysToRelease []arrow.Array
resultsToRelease []arrow.Record

err error
}

Expand Down Expand Up @@ -180,6 +185,24 @@ func (s *OnlineFeatureService) GetOnlineFeatures(
return err
}

// Release all objects that are no longer required.
for _, statusColumnBuilderToRelease := range s.statusColumnBuildersToRelease {
statusColumnBuilderToRelease.Release()
}
for _, tsColumnBuilderToRelease := range s.tsColumnBuildersToRelease {
tsColumnBuilderToRelease.Release()
}
for _, arrayToRelease := range s.arraysToRelease {
arrayToRelease.Release()
}
for _, resultsToRelease := range s.resultsToRelease {
resultsToRelease.Release()
}
s.statusColumnBuildersToRelease = nil
s.tsColumnBuildersToRelease = nil
s.arraysToRelease = nil
s.resultsToRelease = nil

outputFields := make([]arrow.Field, 0)
outputColumns := make([]arrow.Array, 0)
pool := memory.NewCgoArrowAllocator()
Expand Down Expand Up @@ -212,9 +235,16 @@ func (s *OnlineFeatureService) GetOnlineFeatures(
}
tsColumn := tsColumnBuilder.NewArray()
outputColumns = append(outputColumns, tsColumn)

// Mark builders and arrays for release.
s.statusColumnBuildersToRelease = append(s.statusColumnBuildersToRelease, statusColumnBuilder)
s.tsColumnBuildersToRelease = append(s.tsColumnBuildersToRelease, tsColumnBuilder)
s.arraysToRelease = append(s.arraysToRelease, statusColumn)
s.arraysToRelease = append(s.arraysToRelease, tsColumn)
}

result := array.NewRecord(arrow.NewSchema(outputFields, nil), outputColumns, int64(numRows))
s.resultsToRelease = append(s.resultsToRelease, result)

cdata.ExportArrowRecordBatch(result,
cdata.ArrayFromPtr(output.DataPtr),
Expand Down