Skip to content

feat: Add Snowflake online store (again) #2922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 18 commits into from
Jul 29, 2022
Merged

feat: Add Snowflake online store (again) #2922

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
14fd591
feat: Add snowflake online store
sfc-gh-madkins Jul 2, 2022
40507ef
lint/format
sfc-gh-madkins Jul 2, 2022
6c76b5f
removing missing testing env variables
sfc-gh-madkins Jul 2, 2022
6933e34
test offline store first
sfc-gh-madkins Jul 2, 2022
98e3a5c
snowflake online test fixes
sfc-gh-madkins Jul 2, 2022
41ec30d
format
sfc-gh-madkins Jul 2, 2022
49286d0
fix snowflake testing (#2903)
sfc-gh-madkins Jul 2, 2022
fb534ec
change to transient table
sfc-gh-madkins Jul 11, 2022
1ddb4ee
remove extra lines
sfc-gh-madkins Jul 11, 2022
56feaea
docs + nits
sfc-gh-madkins Jul 27, 2022
c38fd29
docs + nits2
sfc-gh-madkins Jul 27, 2022
2309d4e
final docs + nits
sfc-gh-madkins Jul 28, 2022
7a03683
Update sdk/python/feast/infra/online_stores/snowflake.py
sfc-gh-madkins Jul 28, 2022
e1bda4f
Update sdk/python/feast/infra/online_stores/snowflake.py
sfc-gh-madkins Jul 28, 2022
cce1402
Update sdk/python/feast/infra/online_stores/snowflake.py
sfc-gh-madkins Jul 28, 2022
48ae284
Update sdk/python/feast/infra/online_stores/snowflake.py
sfc-gh-madkins Jul 28, 2022
53aa4f7
fix serialization
sfc-gh-madkins Jul 28, 2022
d7d0c04
fix serialization2
sfc-gh-madkins Jul 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lint/format 
Signed-off-by: Miles Adkins <miles.adkins@snowflake.com>
  • Loading branch information
@sfc-gh-madkins
sfc-gh-madkins committed Jul 28, 2022
commit 40507ef85de7cbfc61ad718a9fd5085ebcdf96fa
2 changes: 1 addition & 1 deletion sdk/python/feast/infra/online_stores/snowflake.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ def online_read(
config: RepoConfig,
table: FeatureView,
entity_keys: List[EntityKeyProto],
requested_features: Optional[List[str]] = None,
requested_features: List[str],
) -> List[Tuple[Optional[datetime], Optional[Dict[str, ValueProto]]]]:
assert isinstance(config.online_store, SnowflakeOnlineStoreConfig)

Expand Down
2 changes: 1 addition & 1 deletion sdk/python/tests/integration/feature_repos/repo_configuration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@
"password": os.environ["SNOWFLAKE_CI_PASSWORD"],
"role": os.environ["SNOWFLAKE_CI_ROLE"],
"warehouse": os.environ["SNOWFLAKE_CI_WAREHOUSE"],
"database":os.environ["SNOWFLAKE_CI_DATABASE"],
"database": os.environ["SNOWFLAKE_CI_DATABASE"],
"schema": os.environ["SNOWFLAKE_CI_SCHEMA"],
}

Expand Down