Skip to content

fix: Fix the go build and use CgoArrowAllocator to prevent incorrect garbage collection #2919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevjumba merged 39 commits into from
Jul 8, 2022
Merged

fix: Fix the go build and use CgoArrowAllocator to prevent incorrect garbage collection #2919

Changes from 1 commit
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
a6eafde
Temp fix
kevjumba Jul 6, 2022
2558144
Temp fix
kevjumba Jul 6, 2022
f5b9856
Fix
kevjumba Jul 6, 2022
f3901d3
Fix
kevjumba Jul 6, 2022
99289cd
add dynamic linking flags
kevjumba Jul 6, 2022
b56242d
Update gitignore
kevjumba Jul 7, 2022
70c5efb
Fix
kevjumba Jul 7, 2022
66b1c91
Fix
kevjumba Jul 7, 2022
4532c22
Fix workflows
kevjumba Jul 7, 2022
f0c9d60
Fix
kevjumba Jul 7, 2022
172fc82
Fix
kevjumba Jul 7, 2022
ad46b0b
Fix
kevjumba Jul 7, 2022
16fd288
Fix
kevjumba Jul 7, 2022
4560fee
Fix
kevjumba Jul 7, 2022
ff96f75
Fix
kevjumba Jul 7, 2022
1baa361
Fix
kevjumba Jul 7, 2022
f8e9b2f
Fix
kevjumba Jul 8, 2022
e2c1610
Fix
kevjumba Jul 8, 2022
393c9dc
Fix
kevjumba Jul 8, 2022
205ef73
Fix
kevjumba Jul 8, 2022
b6b1608
Fix
kevjumba Jul 8, 2022
52600af
Fix
kevjumba Jul 8, 2022
1281499
Fix
kevjumba Jul 8, 2022
6bb1da5
Fix
kevjumba Jul 8, 2022
f779bbd
Fix
kevjumba Jul 8, 2022
0fc2ed5
Fix
kevjumba Jul 8, 2022
a8b0a6a
Fix
kevjumba Jul 8, 2022
7dd18c2
Fix
kevjumba Jul 8, 2022
3840495
Fix
kevjumba Jul 8, 2022
687fe79
Fix
kevjumba Jul 8, 2022
b67679b
fix
kevjumba Jul 8, 2022
240a0c1
Fix
kevjumba Jul 8, 2022
00d4808
Fix
kevjumba Jul 8, 2022
ef309f8
Fix
kevjumba Jul 8, 2022
9ee05c9
Fix
kevjumba Jul 8, 2022
3d27b6d
Fix
kevjumba Jul 8, 2022
f644a0f
Fix
kevjumba Jul 8, 2022
b446acb
fix
kevjumba Jul 8, 2022
c17f6fc
Fix
kevjumba Jul 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix 
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
  • Loading branch information
@kevjumba
kevjumba committed Jul 8, 2022
commit f644a0fb846ecec2bcbd22c0d98194b0bfec338c
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,11 +188,11 @@ compile-protos-go: install-go-proto-dependencies install-protoc-dependencies
compile-go-lib: install-go-proto-dependencies install-go-ci-dependencies
CGO_LDFLAGS_ALLOW=".*" COMPILE_GO=True python setup.py build_ext --inplace

install-local-feast:
install-feast-ci-locally:
pip install -e ".[ci]"

# Needs feast package to setup the feature store
test-go: compile-protos-go compile-go-lib install-local-feast
test-go: compile-protos-go compile-go-lib install-feast-ci-locally
CGO_LDFLAGS_ALLOW=".*" go test -tags cgo,ccalloc ./...

format-go:
Expand Down