Skip to content

chore: Refactor StreamFeatureViewMeta to FeatureViewMeta and dedupe #2915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 3 commits into from
Jul 6, 2022
Merged

chore: Refactor StreamFeatureViewMeta to FeatureViewMeta and dedupe #2915

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3503c1b
chore: Refactor StreamFeatureViewMeta to FeatureViewMeta and deduplic…
achals Jul 6, 2022
46b9254
ttl_duration
achals Jul 6, 2022
6a27bfc
nits
achals Jul 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ttl_duration 
Signed-off-by: Achal Shah <achals@gmail.com>
  • Loading branch information
@achals
achals committed Jul 6, 2022
commit 46b92548b4db0ad5091d789f2fc0ef19deacd084
13 changes: 8 additions & 5 deletions sdk/python/feast/feature_view.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,11 +408,7 @@ def to_proto(self) -> FeatureViewProto:
A FeatureViewProto protobuf.
"""
meta = self.to_proto_meta()

ttl_duration = None
if self.ttl is not None:
ttl_duration = Duration()
ttl_duration.FromTimedelta(self.ttl)
ttl_duration = self.ttl_duration()

batch_source_proto = self.batch_source.to_proto()
batch_source_proto.data_source_class_type = f"{self.batch_source.__class__.__module__}.{self.batch_source.__class__.__name__}"
Expand Down Expand Up @@ -451,6 +447,13 @@ def to_proto_meta(self):
meta.materialization_intervals.append(interval_proto)
return meta

def ttl_duration(self):
Comment thread
achals marked this conversation as resolved.
Outdated
ttl_duration = None
if self.ttl is not None:
ttl_duration = Duration()
ttl_duration.FromTimedelta(self.ttl)
return ttl_duration

@classmethod
def from_proto(cls, feature_view_proto: FeatureViewProto):
"""
Expand Down
7 changes: 1 addition & 6 deletions sdk/python/feast/stream_feature_view.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
from typing import Dict, List, Optional, Tuple, Union

import dill
from google.protobuf.duration_pb2 import Duration
from typeguard import typechecked

from feast import utils
Expand Down Expand Up @@ -165,11 +164,7 @@ def __hash__(self) -> int:

def to_proto(self):
meta = self.to_proto_meta()

ttl_duration = None
if self.ttl is not None:
ttl_duration = Duration()
ttl_duration.FromTimedelta(self.ttl)
ttl_duration = self.ttl_duration()

batch_source_proto = None
if self.batch_source:
Expand Down