Skip to content

feat: Add snowflake online store #2902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sfc-gh-madkins merged 7 commits into from
Jul 3, 2022
Merged

feat: Add snowflake online store #2902

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c2e089a
feat: Add snowflake online store
sfc-gh-madkins Jul 2, 2022
4f3785f
lint/format
sfc-gh-madkins Jul 2, 2022
4e5ba80
removing missing testing env variables
sfc-gh-madkins Jul 2, 2022
49a9d52
test offline store first
sfc-gh-madkins Jul 2, 2022
e07c1d0
snowflake online test fixes
sfc-gh-madkins Jul 2, 2022
2bb4e92
format
sfc-gh-madkins Jul 2, 2022
968bd2d
fix snowflake testing (#2903)
sfc-gh-madkins Jul 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
snowflake online test fixes 
Signed-off-by: Miles Adkins <miles.adkins@snowflake.com>
  • Loading branch information
@sfc-gh-madkins
sfc-gh-madkins committed Jul 3, 2022
commit e07c1d0f7dd429aeb14fc879e7e683f8d2895289
6 changes: 4 additions & 2 deletions sdk/python/tests/integration/feature_repos/repo_configuration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,14 +81,16 @@
"password": os.environ["SNOWFLAKE_CI_PASSWORD"],
"role": os.environ["SNOWFLAKE_CI_ROLE"],
"warehouse": os.environ["SNOWFLAKE_CI_WAREHOUSE"],
"database": "FEAST",
"schema": "ONLINE",
}


OFFLINE_STORE_TO_PROVIDER_CONFIG: Dict[str, DataSourceCreator] = {
"file": ("local", FileDataSourceCreator),
"bigquery": ("gcp", BigQueryDataSourceCreator),
"redshift": ("aws", RedshiftDataSourceCreator),
"snowflake": ("aws", SnowflakeDataSourceCreator),
"snowflake": ("aws", RedshiftDataSourceCreator),
}

AVAILABLE_OFFLINE_STORES: List[Tuple[str, Type[DataSourceCreator]]] = [
Expand All @@ -113,7 +115,7 @@
AVAILABLE_ONLINE_STORES["redis"] = (REDIS_CONFIG, None)
AVAILABLE_ONLINE_STORES["dynamodb"] = (DYNAMO_CONFIG, None)
AVAILABLE_ONLINE_STORES["datastore"] = ("datastore", None)
#AVAILABLE_ONLINE_STORES["snowflake"] = (SNOWFLAKE_CONFIG, None)
AVAILABLE_ONLINE_STORES["snowflake"] = (SNOWFLAKE_CONFIG, None)


full_repo_configs_module = os.environ.get(FULL_REPO_CONFIGS_MODULE_ENV_NAME)
Expand Down