-
Notifications
You must be signed in to change notification settings - Fork 1.3k
chore: Update docs with new release workflow #2898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 6 commits
ecf99f0
54d9fbe
00651be
748213b
136258d
b779e51
1820ae9
cdb5005
4f1c410
ae4bc72
256bc63
a8ca125
8bc5b1c
bb2e4c7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,60 +4,27 @@ | |
|
|
||
| For Feast maintainers, these are the concrete steps for making a new release. | ||
|
|
||
| 1. For new major or minor release, create and check out the release branch for the new stream, e.g. `v0.6-branch`. For a patch version, check out the stream's release branch. | ||
| 2. Update the [CHANGELOG.md](../../CHANGELOG.md). See the [Creating a change log](release-process.md#creating-a-change-log) guide and commit | ||
| * Make to review each PR in the changelog to [flag any breaking changes and deprecation.](release-process.md#flag-breaking-changes-and-deprecations) | ||
| 3. Update versions for the release/release candidate with a commit: | ||
| 1. In the root `pom.xml`, remove `-SNAPSHOT` from the `<revision>` property, update versions, and commit. | ||
| 2. Tag the commit with the release version, using a `v` and `sdk/go/v` prefixes | ||
| * for a release candidate, create tags `vX.Y.Z-rc.N`and `sdk/go/vX.Y.Z-rc.N` | ||
| * for a stable release `X.Y.Z` create tags `vX.Y.Z` and `sdk/go/vX.Y.Z` | ||
| 3. Check that versions are updated with `make lint-versions`. | ||
| 4. If changes required are flagged by the version lint, make the changes, amend the commit and move the tag to the new commit. | ||
| 4. Push the commits and tags. Make sure the CI passes. | ||
| * If the CI does not pass, or if there are new patches for the release fix, repeat step 2 & 3 with release candidates until stable release is achieved. | ||
| 5. Bump to the next patch version in the release branch, append `-SNAPSHOT` in `pom.xml` and push. | ||
| 6. Create a PR against master to: | ||
| 1. Bump to the next major/minor version and append `-SNAPSHOT` . | ||
| 2. Add the change log by applying the change log commit created in step 2. | ||
| 3. Check that versions are updated with `env TARGET_MERGE_BRANCH=master make lint-versions` | ||
| 7. Create a [GitHub release](https://github.com/feast-dev/feast/releases) which includes a summary of im~~p~~ortant changes as well as any artifacts associated with the release. Make sure to include the same change log as added in [CHANGELOG.md](../../CHANGELOG.md). Use `Feast vX.Y.Z` as the title. | ||
|
|
||
| When a tag that matches a Semantic Version string is pushed, CI will automatically build and push the relevant artifacts to their repositories or package managers (docker images, Python wheels, etc). JVM artifacts are promoted from Sonatype OSSRH to Maven Central, but it sometimes takes some time for them to be available. The `sdk/go/v tag` is required to version the Go SDK go module so that users can go get a specific tagged release of the Go SDK. | ||
|
|
||
| ### Creating a change log | ||
|
|
||
| We use an [open source change log generator](https://hub.docker.com/r/ferrarimarco/github-changelog-generator/) to generate change logs. The process still requires a little bit of manual effort. | ||
|
|
||
| 1. Create a GitHub token as [per these instructions](https://github.com/github-changelog-generator/github-changelog-generator#github-token). The token is used as an input argument (`-t`) to the change log generator. | ||
| 2. The change log generator configuration below will look for unreleased changes on a specific branch. The branch will be `master` for a major/minor release, or a release branch (`v0.4-branch`) for a patch release. You will need to set the branch using the `--release-branch` argument. | ||
| 3. You should also set the `--future-release` argument. This is the version you are releasing. The version can still be changed at a later date. | ||
| 4. Update the arguments below and run the command to generate the change log to the console. | ||
|
|
||
| ``` | ||
| docker run -it --rm ferrarimarco/github-changelog-generator \ | ||
| --user feast-dev \ | ||
| --project feast \ | ||
| --release-branch <release-branch-to-find-changes> \ | ||
| --future-release <proposed-release-version> \ | ||
| --unreleased-only \ | ||
| --no-issues \ | ||
| --bug-labels kind/bug \ | ||
| --enhancement-labels kind/feature \ | ||
| --breaking-labels compat/breaking \ | ||
| -t <your-github-token> \ | ||
| --max-issues 1 \ | ||
| -o | ||
| ``` | ||
|
|
||
| 1. Review each change log item. | ||
| * Make sure that sentences are grammatically correct and well formatted (although we will try to enforce this at the PR review stage). | ||
| * Make sure that each item is categorised correctly. You will see the following categories: `Breaking changes`, `Implemented enhancements`, `Fixed bugs`, and `Merged pull requests`. Any unlabelled PRs will be found in `Merged pull requests`. It's important to make sure that any `breaking changes`, `enhancements`, or `bug fixes` are pulled up out of `merged pull requests` into the correct category. Housekeeping, tech debt clearing, infra changes, or refactoring do not count as `enhancements`. Only enhancements a user benefits from should be listed in that category. | ||
| * Make sure that the "Full Change log" link is actually comparing the correct tags (normally your released version against the previously version). | ||
| * Make sure that release notes and breaking changes are present. | ||
| ### Pre-release Verification (Verification that wheels are built correctly) | ||
|
|
||
| 1. Merge upstream master changes into your fork. | ||
| 2. Create a tag manually for the release on your fork. For example, if your release doing a release for version 0.22.0, create a tag by doing the following. | ||
|
felixwang9817 marked this conversation as resolved.
Outdated
|
||
| - Checkout master branch and run `git tag v0.22.0`. | ||
| - Run `git push --tags` to push the tag to remote. | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To push the tag to your forks master branch.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed |
||
| 3. Access the `Actions` tab on your github UI on your fork and click the `build_wheels` action. | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What does this workflow do? What does it build? What combinations?
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed. |
||
| 4. Look for the header `This workflow has a workflow_dispatch event trigger` and click `Run Workflow` on the right. | ||
| 5. Run the branch off of the tag you just created(`v0.22.0` in this case) and verify that the workflow worked. | ||
|
felixwang9817 marked this conversation as resolved.
Outdated
felixwang9817 marked this conversation as resolved.
Outdated
|
||
|
|
||
| ### Release | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What stuff does this workflow do? Python release? Java release? UI release? Helm charts? Docker images?
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Clarified |
||
| 1. Generate a [Personal Access Token](https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/creating-a-personal-access-token) or retrieve your saved personal access token. | ||
| - The personal access token should have all of the permissions under the `repo` checkbox. | ||
| 2. Access the `Actions` tab on the main `feast-dev/feast` repo and find the `release` action. | ||
| 3. Look for the header `This workflow has a workflow_dispatch event trigger` again and click `Run Workflow` on the right. | ||
| 4. Try the dry run first with your personal access token. If this succeeds, uncheck `Dry Run` and run the release workflow. | ||
| 5. All of the jobs should succeed besides the UI job which needs to be released separately. Ping a maintainer on Slack to run the UI release manually. | ||
| 6. Try to install the feast release in your local environment and test out the `feast init` -> `feast apply` workflow to verify as a sanity check that the release worked correctly. | ||
|
|
||
| ### Flag Breaking Changes & Deprecations | ||
|
|
||
| It's important to flag breaking changes and deprecation to the API for each release so that we can maintain API compatibility. | ||
|
|
||
| Developers should have flagged PRs with breaking changes with the `compat/breaking` label. However, it's important to double check each PR's release notes and contents for changes that will break API compatibility and manually label `compat/breaking` to PRs with undeclared breaking changes. The change log will have to be regenerated if any new labels have to be added. | ||
| Developers should have flagged PRs with breaking changes with the `compat/breaking` label. However, it's important to double check each PR's release notes and contents for changes that will break API compatibility and manually label `compat/breaking` to PRs with undeclared breaking changes. | ||
|
felixwang9817 marked this conversation as resolved.
Outdated
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this should have two sections, one on how to run the
build_wheelsworkflow on personal forks with a manually applied tag to verify wheels are being created correctly, and a second on how to run thereleaseworkflow using your personal access token on master in the feast repo.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed