Skip to content

fix: Fix grpc and update protobuf #2894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 31 commits into from
Jun 30, 2022
Merged

fix: Fix grpc and update protobuf #2894

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
dd52cbc
Test
kevjumba Jun 29, 2022
2f6fbc2
Fix
kevjumba Jun 29, 2022
9fa6cd5
Fix workflow
kevjumba Jun 29, 2022
b7b2c11
Fix workflow
kevjumba Jun 29, 2022
7c0e972
Test
kevjumba Jun 29, 2022
ad47069
Fix
kevjumba Jun 29, 2022
160c18e
Fix
kevjumba Jun 29, 2022
f782488
Fix
kevjumba Jun 29, 2022
985d672
test
kevjumba Jun 29, 2022
2fa19af
Fix
kevjumba Jun 29, 2022
fa91bea
Fix
kevjumba Jun 29, 2022
8edd89d
Fix
kevjumba Jun 29, 2022
d5f2000
Fix
kevjumba Jun 29, 2022
c24fee0
test
kevjumba Jun 29, 2022
0c7cb35
Fix
kevjumba Jun 29, 2022
9027a59
Fix protobuf pin version and add path variable
kevjumba Jun 29, 2022
1edb15c
Revert setup
kevjumba Jun 29, 2022
25b090d
Update 3.8
kevjumba Jun 29, 2022
61e1aec
Fix
kevjumba Jun 29, 2022
f75d9ab
Update 3.10
kevjumba Jun 29, 2022
3b39aaa
update
kevjumba Jun 29, 2022
278cda7
Fix
kevjumba Jun 29, 2022
3d63de0
Fix
kevjumba Jun 29, 2022
698e335
Fix
kevjumba Jun 29, 2022
2b8cbe9
Fix test
kevjumba Jun 29, 2022
4f5ec88
Fix
kevjumba Jun 30, 2022
c7c9ff1
Update go with grpc 1.47
kevjumba Jun 30, 2022
ca1fd4b
Fix
kevjumba Jun 30, 2022
d875c61
Fix
kevjumba Jun 30, 2022
c6d2ef7
Fix
kevjumba Jun 30, 2022
7a7a473
Fix
kevjumba Jun 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix protobuf pin version and add path variable 
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
  • Loading branch information
@kevjumba
kevjumba committed Jun 30, 2022
commit 9027a59992a8a815933045bd9fa0f6574d30f63c
6 changes: 3 additions & 3 deletions sdk/python/feast/proto_json.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def to_json_object(printer: _Printer, message: ProtoMessage) -> JsonObject:
return value

def from_json_object(
parser: _Parser, value: JsonObject, message: ProtoMessage,
parser: _Parser, value: JsonObject, message: ProtoMessage, path: str
) -> None:
if value is None:
message.null_val = 0
Expand Down Expand Up @@ -142,7 +142,7 @@ def to_json_object(printer: _Printer, message: ProtoMessage) -> JsonObject:
return [printer._MessageToJsonObject(item) for item in message.val]

def from_json_object(
parser: _Parser, value: JsonObject, message: ProtoMessage,
parser: _Parser, value: JsonObject, message: ProtoMessage, path: str
) -> None:
array = value if isinstance(value, list) else value["val"]
for item in array:
Expand Down Expand Up @@ -183,7 +183,7 @@ def to_json_object(printer: _Printer, message: ProtoMessage) -> JsonObject:
return list(message.val)

def from_json_object(
parser: _Parser, value: JsonObject, message: ProtoMessage,
parser: _Parser, value: JsonObject, message: ProtoMessage, path: str
) -> None:
array = value if isinstance(value, list) else value["val"]
message.val.extend(array)
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
"numpy>=1.22,<2",
"pandas>=1,<2",
"pandavro==1.5.*",
"protobuf>=3.10,<=3.20.1",
"protobuf>=3.10,<4",
Copy link
Copy Markdown
Member

@achals achals Jun 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"protobuf>=3.10,<4",
"protobuf>3.20,<4",

Copy link
Copy Markdown
Collaborator Author

@kevjumba kevjumba Jun 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed,

"proto-plus==1.20.*",
"pyarrow>=4,<7",
"pydantic>=1,<2",
Expand Down