Skip to content

docs: Fix deprecated tag in data source documentation - #2811

Closed
achals wants to merge 1 commit into
feast-dev:masterfrom
achals:achal/update-ds
Closed

docs: Fix deprecated tag in data source documentation#2811
achals wants to merge 1 commit into
feast-dev:masterfrom
achals:achal/update-ds

Conversation

@achals

@achals achals commented Jun 17, 2022

Copy link
Copy Markdown
Member

Signed-off-by: Achal Shah achals@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #2809

@achals
docs: Fix deprecated tag in data source documentation
354618d 
Signed-off-by: Achal Shah <achals@gmail.com>
@feast-ci-bot

feast-ci-bot commented Jun 17, 2022

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter

codecov-commenter commented Jun 17, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2811 (354618d) into master (7d57724) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2811      +/-   ##
==========================================
- Coverage   80.56%   80.53%   -0.04%     
==========================================
  Files         172      172              
  Lines       15352    15352              
==========================================
- Hits        12369    12364       -5     
- Misses       2983     2988       +5
Flag Coverage Δ
integrationtests 70.27% <ø> (-0.29%) ⬇️
unittests 59.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/data_source.py 83.70% <ø> (ø)
.../integration/offline_store/test_feature_logging.py 95.45% <0.00%> (-4.55%) ⬇️
...ion/registration/test_stream_feature_view_apply.py 94.23% <0.00%> (-3.85%) ⬇️
...ython/feast/embedded_go/online_features_service.py 89.14% <0.00%> (-0.78%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d57724...354618d. Read the comment docs.

@achals

achals commented Jun 17, 2022

Copy link
Copy Markdown
Member Author

Closing in favor of #2804

@achals achals closed this Jun 17, 2022
@achals
achals deleted the achal/update-ds branch June 17, 2022 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

approved size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

event_timestamp_column showing as deprecated in documentation

3 participants

@achals @feast-ci-bot @codecov-commenter