Skip to content

chore: Update Lombok to 1.18.24#2762

Merged
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
Agent007:lombok-update
Jun 8, 2022
Merged

chore: Update Lombok to 1.18.24#2762
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
Agent007:lombok-update

Conversation

@Agent007
Copy link
Copy Markdown
Contributor

@Agent007 Agent007 commented Jun 7, 2022 •
edited
Loading

What this PR does / why we need it:

Updates Lombok to a newer version in order to address the error message described in https://stackoverflow.com/questions/66801256/java-lang-illegalaccesserror-class-lombok-javac-apt-lombokprocessor-cannot-acce

Which issue(s) this PR fixes:

N/A

@Agent007 Agent007 changed the title chore: update Lombok to 1.18.24 chore: Update Lombok to 1.18.24 Jun 7, 2022
@Agent007
chore: Update Lombok to 1.18.24
f73d544 
Signed-off-by: Jeff <jeffxl@apple.com>
@Agent007 Agent007 marked this pull request as ready for review June 7, 2022 02:15
@Agent007
Copy link
Copy Markdown
Contributor Author

Agent007 commented Jun 7, 2022

/assign @mavysavydav

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 7, 2022 •
edited
Loading

Codecov Report

Merging #2762 (8530f55) into master (7d16516) will decrease coverage by 21.06%.
The diff coverage is n/a.

❗ Current head 8530f55 differs from pull request most recent head f73d544. Consider uploading reports for the commit f73d544 to get more accurate results

@@             Coverage Diff             @@
##           master    #2762       +/-   ##
===========================================
- Coverage   80.59%   59.52%   -21.07%     
===========================================
  Files         173      173               
  Lines       15008    15008               
===========================================
- Hits        12095     8933     -3162     
- Misses       2913     6075     +3162
Flag Coverage Δ
integrationtests ?
unittests 59.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../integration/online_store/test_online_retrieval.py 16.84% <0.00%> (-83.16%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 19.35% <0.00%> (-80.65%) ⬇️
...fline_store/test_universal_historical_retrieval.py 23.80% <0.00%> (-76.20%) ⬇️
.../integration/online_store/test_universal_online.py 17.43% <0.00%> (-73.03%) ⬇️
...ests/integration/e2e/test_python_feature_server.py 28.35% <0.00%> (-71.65%) ⬇️
...dk/python/tests/integration/e2e/test_validation.py 27.77% <0.00%> (-71.43%) ⬇️
sdk/python/feast/wait.py 23.52% <0.00%> (-70.59%) ⬇️
...gration/registration/test_feature_service_apply.py 31.25% <0.00%> (-68.75%) ⬇️
...s/integration/registration/test_universal_types.py 32.25% <0.00%> (-67.75%) ⬇️
sdk/python/tests/utils/logged_features.py 32.65% <0.00%> (-67.35%) ⬇️
... and 73 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d16516...f73d544. Read the comment docs.

@achals
Copy link
Copy Markdown
Member

achals commented Jun 7, 2022

/ok-to-test

@Agent007
Copy link
Copy Markdown
Contributor Author

Agent007 commented Jun 7, 2022

I don't quite understand why the Python 3.7 integration tests failed since I didn't modify anything Python-related.

@woop
Copy link
Copy Markdown
Member

woop commented Jun 7, 2022

@achals is the Python test flaky?

@achals
Copy link
Copy Markdown
Member

achals commented Jun 7, 2022

@achals is the Python test flaky?

We've seen this test become a little more flaky over the past few weeks. We're gonna drill down on this and the flaky tests on master and fix things up.

adchia
adchia approved these changes Jun 8, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

feast-ci-bot commented Jun 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, Agent007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 8a39743 into feast-dev:master Jun 8, 2022
@Agent007 Agent007 deleted the lombok-update branch June 8, 2022 22:40
adchia pushed a commit that referenced this pull request Jun 13, 2022
@Agent007 @adchia
chore: Update Lombok to 1.18.24 (#2762)
5bd6e47 
Signed-off-by: Jeff <jeffxl@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adchia adchia adchia approved these changes

Assignees

@adchia adchia

@mavysavydav mavysavydav

Labels

approved lgtm ok-to-test size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Agent007 @codecov-commenter @achals @woop @feast-ci-bot @adchia @mavysavydav