Skip to content

fix: Fixing Spark min / max entity df event timestamps range return order #2735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 1 commit into from
Jul 25, 2022
Merged

fix: Fixing Spark min / max entity df event timestamps range return order #2735

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: Fixing the return order of elements when calculating the min and… 
… max entity-DF event timestamps in the Spark offline store.

Signed-off-by: Lev Pickovsky <lev.pickovsky@ironsrc.com>
  • Loading branch information
@levpickis
levpickis committed Apr 25, 2022
commit b181bde67b52d3f4e4af4b370181a6f890ae5ebc
2 changes: 1 addition & 1 deletion sdk/python/feast/infra/offline_stores/contrib/spark_offline_store/spark.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,8 +324,8 @@ def _get_entity_df_event_timestamp_range(
df = spark_session.sql(entity_df).select(entity_df_event_timestamp_col)
# TODO(kzhang132): need utc conversion here.
entity_df_event_timestamp_range = (
df.agg({entity_df_event_timestamp_col: "max"}).collect()[0][0],
df.agg({entity_df_event_timestamp_col: "min"}).collect()[0][0],
df.agg({entity_df_event_timestamp_col: "max"}).collect()[0][0],
)
else:
raise InvalidEntityType(type(entity_df))
Expand Down