Skip to content

chore: Local data inspection#2720

Merged
feast-ci-bot merged 1 commit intofeast-dev:masterfrom
ssge:patch-1
May 19, 2022
Merged

chore: Local data inspection#2720
feast-ci-bot merged 1 commit intofeast-dev:masterfrom
ssge:patch-1

Conversation

@ssge
Copy link
Copy Markdown
Contributor

@ssge ssge commented May 19, 2022

fix for #2694

adding the example code from the Google Codelab notebook
moving the image below the yaml and example.py explanation

Signed-off-by: ssge george.kremenliev@gmail.com

What this PR does / why we need it: improving the docs

Which issue(s) this PR fixes:

Fixes #2694

@ssge
Chore: Local data inspection
8698ebf 
fix for #2694 

adding the example code from the Google Codelab notebook
moving the image below the yaml and example.py explanation 

Signed-off-by: ssge <george.kremenliev@gmail.com>
@ssge ssge changed the title Chore: Local data inspection chore: Local data inspection May 19, 2022
@ssge
Copy link
Copy Markdown
Contributor Author

ssge commented May 19, 2022

/assign @mavysavydav

@achals
Copy link
Copy Markdown
Member

achals commented May 19, 2022

/ok-to-test

@achals achals assigned achals and unassigned mavysavydav May 19, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 19, 2022 •
edited
Loading

Codecov Report

Merging #2720 (8698ebf) into master (f4eed30) will decrease coverage by 0.48%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2720      +/-   ##
==========================================
- Coverage   80.27%   79.78%   -0.49%     
==========================================
  Files         167      167              
  Lines       14108    14336     +228     
==========================================
+ Hits        11325    11438     +113     
- Misses       2783     2898     +115
Flag Coverage Δ
integrationtests 70.34% <ø> (-0.36%) ⬇️
unittests 58.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...on/tests/integration/e2e/test_go_feature_server.py 80.00% <0.00%> (-20.00%) ⬇️
...ython/feast/embedded_go/online_features_service.py 75.16% <0.00%> (-15.36%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 93.54% <0.00%> (-6.46%) ⬇️
.../integration/online_store/test_online_retrieval.py 96.84% <0.00%> (-3.16%) ⬇️
sdk/python/feast/feature_store.py 85.51% <0.00%> (-2.71%) ⬇️
sdk/python/feast/cli.py 40.74% <0.00%> (+1.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4eed30...8698ebf. Read the comment docs.

achals
achals approved these changes May 19, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Copy Markdown
Collaborator

feast-ci-bot commented May 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, ssge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit b0e2a8d into feast-dev:master May 19, 2022
@ssge ssge deleted the patch-1 branch May 20, 2022 03:23
adchia pushed a commit that referenced this pull request May 20, 2022
@ssge @adchia
chore: Local data inspection (#2720)
91f901c 
fix for #2694 

adding the example code from the Google Codelab notebook
moving the image below the yaml and example.py explanation 

Signed-off-by: ssge <george.kremenliev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@achals achals achals approved these changes

Assignees

@achals achals

Labels

approved lgtm ok-to-test size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unclear how to get the parquet data dump in the Quickstart docs

5 participants

@ssge @achals @codecov-commenter @feast-ci-bot @mavysavydav