Skip to content

chore: Add request source and ODFV to version 0.19 test repo - #2691

Merged
feast-ci-bot merged 4 commits into
feast-dev:masterfrom
felixwang9817:add_odfvs
May 23, 2022
Merged

chore: Add request source and ODFV to version 0.19 test repo#2691
feast-ci-bot merged 4 commits into
feast-dev:masterfrom
felixwang9817:add_odfvs

Conversation

@felixwang9817

@felixwang9817 felixwang9817 commented May 14, 2022

Copy link
Copy Markdown
Collaborator

Signed-off-by: Felix Wang wangfelix98@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

@codecov-commenter

codecov-commenter commented May 14, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2691 (bffb0fb) into master (c5539fd) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2691      +/-   ##
==========================================
+ Coverage   80.19%   80.23%   +0.04%     
==========================================
  Files         167      167              
  Lines       14021    14118      +97     
==========================================
+ Hits        11244    11328      +84     
- Misses       2777     2790      +13
Flag Coverage Δ
integrationtests 70.27% <33.33%> (-0.55%) ⬇️
unittests 59.13% <100.00%> (+0.53%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/on_demand_feature_view.py 81.06% <ø> (-0.94%) ⬇️
sdk/python/feast/data_source.py 83.86% <100.00%> (ø)
...n/tests/integration/online_store/test_e2e_local.py 100.00% <100.00%> (ø)
sdk/python/feast/flags_helper.py 82.35% <0.00%> (-11.77%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 93.54% <0.00%> (-6.46%) ⬇️
.../integration/online_store/test_online_retrieval.py 96.84% <0.00%> (-3.16%) ⬇️
sdk/python/tests/conftest.py 78.83% <0.00%> (-2.92%) ⬇️
sdk/python/feast/feature_service.py 92.39% <0.00%> (-1.09%) ⬇️
...ython/feast/embedded_go/online_features_service.py 89.65% <0.00%> (-0.87%) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5539fd...bffb0fb. Read the comment docs.

@achals

achals commented May 16, 2022

Copy link
Copy Markdown
Member

Seems like ODFVs need to be enabled for the unit tests:

Traceback (most recent call last):
  File "/home/runner/work/feast/feast/sdk/python/feast/cli.py", line 752, in <module>
    cli()
  File "/opt/hostedtoolcache/Python/3.7.13/x64/lib/python3.7/site-packages/click/core.py", line 1137, in __call__
    return self.main(*args, **kwargs)
  File "/opt/hostedtoolcache/Python/3.7.13/x64/lib/python3.7/site-packages/click/core.py", line 1062, in main
    rv = self.invoke(ctx)
  File "/opt/hostedtoolcache/Python/3.7.13/x64/lib/python3.7/site-packages/click/core.py", line 1668, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/opt/hostedtoolcache/Python/3.7.13/x64/lib/python3.7/site-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/opt/hostedtoolcache/Python/3.7.13/x64/lib/python3.7/site-packages/click/core.py", line 763, in invoke
    return __callback(*args, **kwargs)
  File "/opt/hostedtoolcache/Python/3.7.13/x64/lib/python3.7/site-packages/click/decorators.py", line 26, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/home/runner/work/feast/feast/sdk/python/feast/cli.py", line 489, in apply_total_command
    apply_total(repo_config, repo, skip_source_validation)
  File "/home/runner/work/feast/feast/sdk/python/feast/repo_operations.py", line 277, in apply_total
    store, project, registry, repo, skip_source_validation
  File "/home/runner/work/feast/feast/sdk/python/feast/repo_operations.py", line 236, in apply_total_with_repo_instance
    registry_diff, infra_diff, new_infra = store._plan(repo)
  File "/home/runner/work/feast/feast/sdk/python/feast/feature_store.py", line 554, in _plan
    desired_repo_contents.request_feature_views,
  File "/home/runner/work/feast/feast/sdk/python/feast/feature_store.py", line 465, in _validate_all_feature_views
    raise ExperimentalFeatureNotEnabled(flags.FLAG_ON_DEMAND_TRANSFORM_NAME)
feast.errors.ExperimentalFeatureNotEnabled: You are attempting to use an experimental feature that is not enabled. Please run `feast alpha enable on_demand_transforms`

@adchia

adchia commented May 16, 2022

Copy link
Copy Markdown
Collaborator

probably worth deprecating the flags now too and just outputting that warning instead

@felixwang9817
Add request source and ODFV to version 0.19 test repo
40a067a 
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@felixwang9817
Format
8194e5d 
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@felixwang9817
Enable ODFVs for unit tests
8f33d26 
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@felixwang9817

felixwang9817 commented May 18, 2022

Copy link
Copy Markdown
Collaborator Author

probably worth deprecating the flags now too and just outputting that warning instead
yup can do that in a future PR

adchia
adchia reviewed May 19, 2022
View reviewed changes
Comment thread sdk/python/tests/example_repos/example_feature_repo_version_0_19.py Outdated
@felixwang9817
Switch to RequestDataSource
bffb0fb 
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
adchia
adchia approved these changes May 23, 2022
View reviewed changes

@adchia adchia left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot

feast-ci-bot commented May 23, 2022

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [adchia,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot
feast-ci-bot merged commit 44d53fd into feast-dev:master May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adchia adchia adchia approved these changes

Assignees

@adchia adchia

@felixwang9817 felixwang9817

Labels

approved lgtm size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@felixwang9817 @codecov-commenter @achals @adchia @feast-ci-bot