Skip to content

chore: Fix the version checker for upcoming release - #2688

Merged
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
achals:achal/fix-version-check
May 13, 2022
Merged

chore: Fix the version checker for upcoming release#2688
feast-ci-bot merged 1 commit into
feast-dev:masterfrom
achals:achal/fix-version-check

Conversation

@achals

@achals achals commented May 13, 2022

Copy link
Copy Markdown
Member

Signed-off-by: Achal Shah achals@gmail.com

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Signed-off-by: Achal Shah <achals@gmail.com>

@adchia adchia left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter

codecov-commenter commented May 13, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2688 (d8044e7) into master (01d3568) will decrease coverage by 22.32%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #2688       +/-   ##
===========================================
- Coverage   80.99%   58.66%   -22.33%     
===========================================
  Files         166      166               
  Lines       13872    13888       +16     
===========================================
- Hits        11236     8148     -3088     
- Misses       2636     5740     +3104     
Flag Coverage Δ
integrationtests ?
unittests 58.66% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../integration/online_store/test_online_retrieval.py 16.84% <0.00%> (-80.00%) ⬇️
.../integration/online_store/test_universal_online.py 17.64% <0.00%> (-77.78%) ⬇️
...fline_store/test_universal_historical_retrieval.py 24.17% <0.00%> (-75.83%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 19.35% <0.00%> (-74.20%) ⬇️
...ests/integration/e2e/test_python_feature_server.py 28.35% <0.00%> (-71.65%) ⬇️
sdk/python/feast/wait.py 23.52% <0.00%> (-70.59%) ⬇️
...gration/registration/test_feature_service_apply.py 31.25% <0.00%> (-68.75%) ⬇️
...dk/python/tests/integration/e2e/test_validation.py 32.72% <0.00%> (-67.28%) ⬇️
sdk/python/feast/infra/online_stores/redis.py 28.39% <0.00%> (-66.67%) ⬇️
sdk/python/tests/integration/e2e/test_usage_e2e.py 33.87% <0.00%> (-66.13%) ⬇️
... and 73 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01d3568...d8044e7. Read the comment docs.

@feast-ci-bot
feast-ci-bot merged commit abc2b2c into feast-dev:master May 13, 2022
@achals
achals deleted the achal/fix-version-check branch May 13, 2022 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants