Skip to content

fix: Use ParquetDataset for Schema Inference #2686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 1 commit into from
May 13, 2022
Merged

fix: Use ParquetDataset for Schema Inference #2686

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Use ParquetDataset for Schema Inference 
Updates to use ParquetDataset instead of ParquetFile to do schema inference.  This supports both single files and directories of partitioned parquet datasets.

Signed-off-by: Dirk Van Bruggen <dirk@punchcyber.com>
  • Loading branch information
@dvanbrug
dvanbrug committed May 13, 2022
commit 828168170d8827d626a1ab509cd29f7c89b623a0
6 changes: 3 additions & 3 deletions sdk/python/feast/infra/offline_stores/file_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

from pyarrow._fs import FileSystem
from pyarrow._s3fs import S3FileSystem
from pyarrow.parquet import ParquetFile
from pyarrow.parquet import ParquetDataset

from feast import type_map
from feast.data_format import FileFormat, ParquetFormat
Expand Down Expand Up @@ -179,9 +179,9 @@ def get_table_column_names_and_types(
filesystem, path = FileSource.create_filesystem_and_path(
self.path, self.file_options.s3_endpoint_override
)
schema = ParquetFile(
schema = ParquetDataset(
path if filesystem is None else filesystem.open_input_file(path)
).schema_arrow
).schema.to_arrow_schema()
return zip(schema.names, map(str, schema.types))

@staticmethod
Expand Down