Skip to content

fix: Punt deprecation warnings and clean up some warnings. #2670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adchia merged 3 commits into from
May 11, 2022
Merged

fix: Punt deprecation warnings and clean up some warnings. #2670

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9fbf1ec
Add some fixes
kevjumba May 6, 2022
f87cec7
Punt deprecation warnings to 0.23
kevjumba May 11, 2022
c326a89
Fix lint
kevjumba May 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add some fixes 
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
  • Loading branch information
@kevjumba
kevjumba committed May 11, 2022
commit 9fbf1ecbc50591877f09918e818d14fbbc63d316
2 changes: 2 additions & 0 deletions sdk/python/feast/infra/offline_stores/contrib/spark_offline_store/spark.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@
from feast.type_map import spark_schema_to_np_dtypes
from feast.usage import log_exceptions_and_usage

# Make sure spark warning doesn't raise more than once.
warnings.simplefilter("once", RuntimeWarning)

class SparkOfflineStoreConfig(FeastConfigBaseModel):
type: StrictStr = "spark"
Expand Down
2 changes: 2 additions & 0 deletions sdk/python/feast/infra/offline_stores/offline_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@
if TYPE_CHECKING:
from feast.saved_dataset import ValidationReference

warnings.simplefilter("once", RuntimeWarning)


class RetrievalMetadata:
min_event_timestamp: Optional[datetime]
Expand Down