Skip to content

Python SDK enhancements #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
woop merged 6 commits into from
Oct 22, 2019
Merged

Python SDK enhancements #264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b736b9e
Python SDK enhancements
woop Oct 22, 2019
e7ff946
Update Version check for Feast Serving and fix type for get_feature_set
woop Oct 22, 2019
f4807f3
Add more "happy path" unit tests to Python Client
woop Oct 22, 2019
6340c84
Fixed type in docs
woop Oct 22, 2019
5c17822
Add docs, exception handling, and clean up Feast client
woop Oct 22, 2019
56c8d84
Add Optional to max_age of feature set
woop Oct 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 sdk/python/tests/__init__.py → sdk/python/__init__.py
View file
Open in desktop
File renamed without changes.
26 changes: 12 additions & 14 deletions sdk/python/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,11 @@
import click
from feast import config as feast_config
from feast.client import Client
from feast.resource import ResourceFactory
from feast.feature_set import FeatureSet
import toml
import pkg_resources
from feast import resource
from feast.utils import loaders
import yaml
import json

Expand Down Expand Up @@ -131,8 +132,7 @@ def list():
List all feature sets
"""
feast_client = Client(
core_url=feast_config.get_config_property_or_fail("core_url"),
serving_url=feast_config.get_config_property_or_fail("serving_url"),
core_url=feast_config.get_config_property_or_fail("core_url")
) # type: Client

for fs in feast_client.list_feature_sets():
Expand All @@ -146,8 +146,7 @@ def create(name):
Create a feature set
"""
feast_client = Client(
core_url=feast_config.get_config_property_or_fail("core_url"),
serving_url=feast_config.get_config_property_or_fail("serving_url"),
core_url=feast_config.get_config_property_or_fail("core_url")
) # type: Client

feast_client.apply(FeatureSet(name=name))
Expand All @@ -161,8 +160,7 @@ def describe(name, version):
Describe a feature set
"""
feast_client = Client(
core_url=feast_config.get_config_property_or_fail("core_url"),
serving_url=feast_config.get_config_property_or_fail("serving_url"),
core_url=feast_config.get_config_property_or_fail("core_url")
) # type: Client

fs = feast_client.get_feature_set(name=name, version=version)
Expand Down Expand Up @@ -213,20 +211,20 @@ def ingest(name, version, filename, file_type):
"--filename",
"-f",
help="Path to the configuration file that will be applied",
type=click.File("r"),
type=click.Path(exists=True),
)
def apply(filename):
"""
Apply a configuration to a resource by filename or stdin
"""
resources = []
# resources can be divided by a separator of '---'
for resource_yaml in filename.read().split("---"):
resources.append(resource.from_yaml(resource_yaml))

resources = [
ResourceFactory.get_resource(res_dict["kind"]).from_dict(res_dict)
for res_dict in loaders.yaml_loader(filename)
]

feast_client = Client(
core_url=feast_config.get_config_property_or_fail("core_url"),
serving_url=feast_config.get_config_property_or_fail("serving_url"),
core_url=feast_config.get_config_property_or_fail("core_url")
) # type: Client

feast_client.apply(resources)
Expand Down
Loading