Skip to content

Use a symlink for Java SDK's protos - #263

Merged
woop merged 1 commit into
feast-dev:0.3-devfrom
ches:java-sdk-symlink-protos
Oct 21, 2019
Merged

Use a symlink for Java SDK's protos#263
woop merged 1 commit into
feast-dev:0.3-devfrom
ches:java-sdk-symlink-protos

Conversation

@ches

@ches ches commented Oct 19, 2019

Copy link
Copy Markdown
Member

The recently-added Java SDK has source copies of the Feast protos, unlike other modules that use a symlink. Fix that so there is no mistake or head-scratching at generated code differing.

@feast-ci-bot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ches
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: zhilingc

If they are not already assigned, you can assign the PR to them by writing /assign @zhilingc in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot

Copy link
Copy Markdown
Collaborator

Hi @ches. Thanks for your PR.

I'm waiting for a gojek member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@woop

woop commented Oct 20, 2019

Copy link
Copy Markdown
Member

looks good to me

@woop
woop merged commit 225582f into feast-dev:0.3-dev Oct 21, 2019
@ches
ches deleted the java-sdk-symlink-protos branch October 21, 2019 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants