Skip to content

chore: Deprecate value type #2611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 17 commits into from
May 4, 2022
Merged

chore: Deprecate value type #2611

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
59987e1
Switch `entities` from List[str] to List[Entity]
felixwang9817 Apr 25, 2022
1632d9d
Remove `value_type` from SDK
felixwang9817 Apr 26, 2022
4897511
Remove `value_type` from tests
felixwang9817 Apr 26, 2022
428508c
Deprecate `value_type` parameter for Entity
felixwang9817 May 2, 2022
523e021
Add fields for entities to avoid type inference after removing `value…
felixwang9817 Apr 26, 2022
7dda0b4
Fix Go
felixwang9817 May 2, 2022
ac068ec
Fix type inference
felixwang9817 May 3, 2022
d0200ff
Another fix
felixwang9817 May 3, 2022
121480d
Another fix
felixwang9817 May 3, 2022
1f6c700
Rename Entities to EntityNames in go
felixwang9817 May 3, 2022
b0f7ac6
Rename lookup
felixwang9817 May 3, 2022
c83cd08
Rename Feature to Field
felixwang9817 May 3, 2022
acb401f
Clean up inference
felixwang9817 May 3, 2022
b32ac5c
Refactor
felixwang9817 May 3, 2022
e1a4c41
Use old `value_type` attribute if it still exists
felixwang9817 May 3, 2022
8593910
Refactor
felixwang9817 May 3, 2022
50f03b9
Add TODO
felixwang9817 May 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rename lookup 
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
  • Loading branch information
@felixwang9817
felixwang9817 committed May 3, 2022
commit b0f7ac6864e577064b345d213432d1e22d36abde
8 changes: 4 additions & 4 deletions go/internal/feast/model/featureview.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,18 +48,18 @@ func (fv *FeatureView) NewFeatureViewFromBase(base *BaseFeatureView) *FeatureVie
return featureView
}

func (fv *FeatureView) HasEntity(lookup string) bool {
func (fv *FeatureView) HasEntity(name string) bool {
for _, entityName := range fv.EntityNames {
if entityName == lookup {
if entityName == name {
return true
}
}
return false
}

func (fv *FeatureView) GetEntityType(lookup string) types.ValueType_Enum {
func (fv *FeatureView) GetEntityType(joinKey string) types.ValueType_Enum {
for _, entityColumn := range fv.EntityColumns {
if entityColumn.Name == lookup {
if entityColumn.Name == joinKey {
return entityColumn.Dtype
}
}
Expand Down