Skip to content

fix: Update field api to add tag parameter corresponding to labels in Feature. #2610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 12 commits into from
Apr 26, 2022
Merged

fix: Update field api to add tag parameter corresponding to labels in Feature. #2610

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
8e10875
Fix tags
kevjumba Apr 25, 2022
3b8c38d
Fix lint
kevjumba Apr 25, 2022
b9b6bbb
Fix lint
kevjumba Apr 25, 2022
ce5753e
Fix lint
kevjumba Apr 25, 2022
4a83454
Convert field to use optional kw args
kevjumba Apr 25, 2022
0a0e420
fix
kevjumba Apr 25, 2022
5eeb0d4
Fix
kevjumba Apr 25, 2022
ccf6e9b
Fix
kevjumba Apr 25, 2022
fab96ec
Fix
kevjumba Apr 26, 2022
3654ebb
Fix
kevjumba Apr 26, 2022
7d3975f
Fix lint
kevjumba Apr 26, 2022
fbf27be
Fix java tests
kevjumba Apr 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix java tests 
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
  • Loading branch information
@kevjumba
kevjumba committed Apr 26, 2022
commit fbf27be363f12ff4044c3da12383cddbb2959e7e
16 changes: 8 additions & 8 deletions java/serving/src/test/java/feast/serving/util/DataGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,11 +126,11 @@ public static EntityProto.EntitySpecV2 createEntitySpecV2(
}

public static FeatureProto.FeatureSpecV2 createFeatureSpecV2(
String name, ValueProto.ValueType.Enum valueType, Map<String, String> labels) {
String name, ValueProto.ValueType.Enum valueType, Map<String, String> tags) {
return FeatureProto.FeatureSpecV2.newBuilder()
.setName(name)
.setValueType(valueType)
.putAllLabels(labels)
.putAllTags(tags)
.build();
}

Expand All @@ -140,7 +140,7 @@ public static FeatureTableSpec createFeatureTableSpec(
List<String> entities,
Map<String, ValueProto.ValueType.Enum> features,
int maxAgeSecs,
Map<String, String> labels) {
Map<String, String> tags) {

return FeatureTableSpec.newBuilder()
.setName(name)
Expand All @@ -152,7 +152,7 @@ public static FeatureTableSpec createFeatureTableSpec(
FeatureSpecV2.newBuilder()
.setName(entry.getKey())
.setValueType(entry.getValue())
.putAllLabels(labels)
.putAllTags(tags)
.build())
.collect(Collectors.toList()))
.setMaxAge(Duration.newBuilder().setSeconds(3600).build())
Expand All @@ -169,7 +169,7 @@ public static FeatureTableSpec createFeatureTableSpec(
.setUri("/dev/null")
.build())
.build())
.putAllLabels(labels)
.putAllLabels(tags)
.build();
}

Expand All @@ -178,7 +178,7 @@ public static FeatureTableSpec createFeatureTableSpec(
List<String> entities,
ImmutableMap<String, ValueProto.ValueType.Enum> features,
int maxAgeSecs,
Map<String, String> labels) {
Map<String, String> tags) {

return FeatureTableSpec.newBuilder()
.setName(name)
Expand All @@ -190,11 +190,11 @@ public static FeatureTableSpec createFeatureTableSpec(
FeatureSpecV2.newBuilder()
.setName(entry.getKey())
.setValueType(entry.getValue())
.putAllLabels(labels)
.putAllTags(tags)
.build())
.collect(Collectors.toList()))
.setMaxAge(Duration.newBuilder().setSeconds(maxAgeSecs).build())
.putAllLabels(labels)
.putAllLabels(tags)
.build();
}

Expand Down