Skip to content

fix: Use C-type long long (8 bytes) type format to pack int64 values #2609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
roelschr wants to merge 4 commits into from
Closed

fix: Use C-type long long (8 bytes) type format to pack int64 values #2609

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5e5e58a
ci: Restore specific files during sdist builds
achals Jun 29, 2022
64fd62f
Use long long type format to serialize int64 values
roelschr Apr 23, 2022
097da5c
Update test to avoid type conversion
roelschr Apr 25, 2022
4d8cdb8
version the serialization mechanism and plumb through all the places
achals Jun 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
ci: Restore specific files during sdist builds 
Signed-off-by: Achal Shah <achals@gmail.com>
  • Loading branch information
@achals
achals committed Jun 29, 2022
commit 5e5e58a9af274ec52b82fcb734fc6b1b5b48db6b
3 changes: 3 additions & 0 deletions .github/workflows/build_wheels.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,12 +108,15 @@ jobs:
node-version: '17.x'
registry-url: 'https://registry.npmjs.org'
- name: Build and install dependencies
# There's a `git restore` in here because `make install-go-ci-dependencies` is actually messing up go.mod & go.sum.
Copy link
Copy Markdown
Collaborator

@felixwang9817 felixwang9817 Jun 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this stuff

run: |
pip install -U pip setuptools wheel twine
make install-protoc-dependencies
make install-go-proto-dependencies
make install-go-ci-dependencies
make build-ui
git status
git restore go.mod go.sum
- name: Build
run: |
python3 setup.py sdist
Expand Down