Skip to content

fix: Fix broken proto conversion methods for data sources #2603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 15 commits into from
Apr 24, 2022
Merged

fix: Fix broken proto conversion methods for data sources #2603

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
da33eb4
Fix Snowflake proto conversion and add test
felixwang9817 Apr 21, 2022
c68f53f
Add proto conversion test for FileSource
felixwang9817 Apr 23, 2022
a2fd043
Fix Redshift proto conversion and add test
felixwang9817 Apr 23, 2022
99413ca
Add proto conversion test for BigQuerySource
felixwang9817 Apr 23, 2022
3587993
Fix tests to use DataSource.from_proto
felixwang9817 Apr 23, 2022
d0175da
Add proto conversion test for KafkaSource
felixwang9817 Apr 23, 2022
56384fa
Add proto conversion test for KinesisSource
felixwang9817 Apr 23, 2022
74734a5
Add proto conversion test for PushSource
felixwang9817 Apr 23, 2022
2d45843
Add proto conversion test for PushSource
felixwang9817 Apr 23, 2022
7abf502
Add name and other fixes
felixwang9817 Apr 23, 2022
f4f6252
Fix proto conversion tests
felixwang9817 Apr 23, 2022
f1caec3
Add tags to test
felixwang9817 Apr 23, 2022
696b10a
Fix BigQuerySource bug
felixwang9817 Apr 24, 2022
4bffc5c
Fix bug in RedshiftSource and TrinoSource
felixwang9817 Apr 24, 2022
0a0cc58
Remove references to event_timestamp_column
felixwang9817 Apr 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix tests to use DataSource.from_proto 
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
  • Loading branch information
@felixwang9817
felixwang9817 committed Apr 23, 2022
commit 358799375bea56cf43a741365709ecfcc6db0ff5
9 changes: 5 additions & 4 deletions sdk/python/tests/unit/test_data_sources.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
from feast import ValueType
from feast.data_format import ProtoFormat
from feast.data_source import (
DataSource,
KafkaSource,
KinesisSource,
PushSource,
Expand Down Expand Up @@ -195,8 +196,8 @@ def test_proto_conversion():
)

assert (
BigQuerySource.from_proto(bigquery_source.to_proto()) == bigquery_source_proto
DataSource.from_proto(bigquery_source.to_proto()) == bigquery_source
)
assert FileSource.from_proto(file_source.to_proto()) == file_source
assert RedshiftSource.from_proto(redshift_source.to_proto()) == redshift_source
assert SnowflakeSource.from_proto(snowflake_source.to_proto()) == snowflake_source
assert DataSource.from_proto(file_source.to_proto()) == file_source
assert DataSource.from_proto(redshift_source.to_proto()) == redshift_source
assert DataSource.from_proto(snowflake_source.to_proto()) == snowflake_source