Skip to content

Change gopath to point to gojek repo - #26

Merged
pradithya merged 1 commit into
feast-dev:masterfrom
zhilingc:gopath-fix
Jan 2, 2019
Merged

Change gopath to point to gojek repo#26
pradithya merged 1 commit into
feast-dev:masterfrom
zhilingc:gopath-fix

Conversation

@zhilingc

@zhilingc zhilingc commented Jan 2, 2019

Copy link
Copy Markdown
Collaborator

From original gojektech repo. Fix for issue #16

@tims

tims commented Jan 2, 2019

Copy link
Copy Markdown
Contributor

Why is the generated go code checked in?

@zhilingc

zhilingc commented Jan 2, 2019

Copy link
Copy Markdown
Collaborator Author

Why is the generated go code checked in?

It needs to be checked in so that other go code bases can reference and pull them. Which is necessary since we have a go sdk.

@tims

tims commented Jan 2, 2019

Copy link
Copy Markdown
Contributor

Ahh ok, go is weird

@tims tims left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pradithya
pradithya merged commit 85dba96 into feast-dev:master Jan 2, 2019
@zhilingc
zhilingc deleted the gopath-fix branch January 14, 2019 09:42
dmartinol pushed a commit to dmartinol/feast that referenced this pull request Jul 1, 2024
Added filter_only flag to assert_permissions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants