Skip to content

chore: Extra dependencies in setup.py for Go <-> Python interop #2589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 2 commits into from
Apr 21, 2022
Merged

chore: Extra dependencies in setup.py for Go <-> Python interop #2589

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
adabcb2
install go dependencies
pyalex Apr 21, 2022
eab7084
allow patch versions for cffi
pyalex Apr 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
install go dependencies 
Signed-off-by: pyalex <moskalenko.alexey@gmail.com>
  • Loading branch information
@pyalex
pyalex committed Apr 21, 2022
commit adabcb2129ecaf7d29e4c0ea9178eafeae2c7336
5 changes: 5 additions & 0 deletions docs/reference/feature-servers/go-feature-retrieval.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@ The Go Feature Retrieval component currently only supports Redis and Sqlite as o

As long as you are running macOS or linux, on x86, with python version 3.7-3.10, the go component comes pre-compiled when you install feast.

However, some additional dependencies are required for Go <-> Python interoperability. To install these dependencies run the following command in your console:
```
pip install feast[go]
```

For developers, if you want to build from source, run `make compile-go-lib` to build and compile the go server.

## Usage
Expand Down
5 changes: 5 additions & 0 deletions sdk/python/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,10 @@
"great_expectations>=0.14.0,<0.15.0"
]

GO_REQUIRED = [
"cffi==1.15.0",
Comment thread
adchia marked this conversation as resolved.
Outdated
]

CI_REQUIRED = (
[
"cryptography==3.4.8",
Expand Down Expand Up @@ -440,6 +444,7 @@ def copy_extensions_to_source(self):
"trino": TRINO_REQUIRED,
"postgres": POSTGRES_REQUIRED,
"ge": GE_REQUIRED,
"go": GO_REQUIRED,
},
include_package_data=True,
license="Apache",
Expand Down