Skip to content

fix: Update on demand feature view api #2587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 21 commits into from
Apr 22, 2022
Merged

fix: Update on demand feature view api #2587

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
3235ce3
Migrate over
kevjumba Apr 20, 2022
27b7b6e
Fix
kevjumba Apr 21, 2022
6f01fd3
Fix
kevjumba Apr 21, 2022
d77f9a1
Fix
kevjumba Apr 21, 2022
fb49cf3
temp fix
kevjumba Apr 21, 2022
14fe923
Fix lint
kevjumba Apr 21, 2022
46eec61
Fix lint
kevjumba Apr 21, 2022
3742cf1
Fix lint
kevjumba Apr 21, 2022
f1f8f27
Fix
kevjumba Apr 21, 2022
7ef6462
Fix import
kevjumba Apr 21, 2022
4c147ee
Fix
kevjumba Apr 21, 2022
e0078b1
Fix
kevjumba Apr 21, 2022
0b9d4fd
Fix lint
kevjumba Apr 21, 2022
390772c
Fix
kevjumba Apr 21, 2022
f6ab5da
Fix lint
kevjumba Apr 21, 2022
2047033
Fix integration tests
kevjumba Apr 21, 2022
4a2125f
Fix integration tests
kevjumba Apr 21, 2022
4b9dd34
Fix
kevjumba Apr 22, 2022
99e0cf5
lilnt
kevjumba Apr 22, 2022
e232ef2
Fix lint?
kevjumba Apr 22, 2022
05617db
Fix
kevjumba Apr 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix 
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
  • Loading branch information
@kevjumba
kevjumba committed Apr 22, 2022
commit 4b9dd34c2a889622e19bb52fb01d1795ce0b464a
4 changes: 2 additions & 2 deletions docs/tutorials/validating-historical-features.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ pyarrow.parquet.write_table(entities_2019_table, "entities.parquet")
import pyarrow.parquet
import pandas as pd

from feast import FeatureView, Entity, FeatureStore, Field
from feast import FeatureView, Entity, FeatureStore, Field, BatchFeatureView
from feast.types import Float64, Int64
from feast.value_type import ValueType
from feast.data_format import ParquetFormat
Expand All @@ -134,7 +134,7 @@ taxi_entity = Entity(name='taxi', join_keys=['taxi_id'])


```python
trips_stats_fv = BaseFeatureView(
trips_stats_fv = BatchFeatureView(
name='trip_stats',
entities=['taxi'],
features=[
Expand Down
4 changes: 2 additions & 2 deletions examples/java-demo/feature_repo/driver_repo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,15 @@
from google.protobuf.duration_pb2 import Duration
from feast.field import Field

from feast import Entity, Feature, BaseFeatureView, FileSource, ValueType
from feast import Entity, Feature, BatchFeatureView, FileSource, ValueType

driver_hourly_stats = FileSource(
path="data/driver_stats_with_string.parquet",
timestamp_field="event_timestamp",
created_timestamp_column="created",
)
driver = Entity(name="driver_id", value_type=ValueType.INT64, description="driver id",)
driver_hourly_stats_view = BaseFeatureView(
driver_hourly_stats_view = BatchFeatureView(
name="driver_hourly_stats",
entities=["driver_id"],
ttl=Duration(seconds=86400000),
Expand Down
31 changes: 6 additions & 25 deletions sdk/python/feast/on_demand_feature_view.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ def __init__( # noqa: C901
name: Optional[str] = None,
features: Optional[List[Feature]] = None,
sources: Optional[
List[Union[BatchFeatureView, StreamFeatureView, RequestSource]]
List[Union[BatchFeatureView, StreamFeatureView, RequestSource, FeatureViewProjection]]
] = None,
udf: Optional[MethodType] = None,
inputs: Optional[
Expand Down Expand Up @@ -139,11 +139,7 @@ def __init__( # noqa: C901
for _, source in inputs.items():
if isinstance(source, FeatureView):
_sources.append(feature_view_to_batch_feature_view(source))
elif isinstance(source, FeatureViewProjection):
_sources.append(
BatchFeatureView(name=source.name, schema=source.features,)
)
elif isinstance(source, RequestSource):
elif isinstance(source, RequestSource) or isinstance(source, FeatureViewProjection):
_sources.append(source)
else:
raise ValueError(
Expand Down Expand Up @@ -186,11 +182,7 @@ def __init__( # noqa: C901
for _, source in _inputs.items():
if isinstance(source, FeatureView):
_sources.append(feature_view_to_batch_feature_view(source))
elif isinstance(source, FeatureViewProjection):
_sources.append(
BatchFeatureView(name=source.name, schema=source.features,)
)
elif isinstance(source, RequestSource):
elif isinstance(source, RequestSource) or isinstance(source, FeatureViewProjection):
_sources.append(source)
else:
raise ValueError(
Expand Down Expand Up @@ -501,7 +493,7 @@ def on_demand_feature_view(
*args,
features: Optional[List[Feature]] = None,
sources: Optional[
List[Union[BatchFeatureView, StreamFeatureView, RequestSource]]
List[Union[BatchFeatureView, StreamFeatureView, RequestSource, FeatureViewProjection]]
] = None,
inputs: Optional[Dict[str, Union[FeatureView, RequestSource]]] = None,
schema: Optional[List[Field]] = None,
Expand Down Expand Up @@ -557,11 +549,7 @@ def on_demand_feature_view(
for _, source in inputs.items():
if isinstance(source, FeatureView):
_sources.append(feature_view_to_batch_feature_view(source))
elif isinstance(source, FeatureViewProjection):
_sources.append(
BatchFeatureView(name=source.name, schema=source.features,)
)
elif isinstance(source, RequestSource):
elif isinstance(source, RequestSource) or isinstance(source, FeatureViewProjection):
_sources.append(source)
else:
raise ValueError(
Expand Down Expand Up @@ -601,14 +589,7 @@ def on_demand_feature_view(
for _, source in _inputs.items():
if isinstance(source, FeatureView):
_sources.append(feature_view_to_batch_feature_view(source))
elif isinstance(source, FeatureViewProjection):
_sources.append(
BatchFeatureView(
name=source.name, # type: ignore
schema=source.features, # type: ignore
)
)
elif isinstance(source, RequestSource):
elif isinstance(source, RequestSource) or isinstance(source, FeatureViewProjection):
_sources.append(source)
else:
raise ValueError(
Expand Down