fix tests

Signed-off-by: pyalex <moskalenko.alexey@gmail.com>
feast-dev · feast-ci-bot · Apr 26, 2022 · Apr 19, 2022 · Apr 19, 2022 · Apr 19, 2022
commit 2681b3c6cffbe4470bb324e824a3ada886f53355
@@ -1,5 +1,5 @@
 import abc
-from typing import TYPE_CHECKING, Dict, Type, cast
+from typing import TYPE_CHECKING, Dict, Optional, Type, cast
 
 import pyarrow as pa
 from pytz import UTC
@@ -133,8 +133,11 @@ def __init__(self, destination: LoggingDestination):
         self.destination = destination
 
     @classmethod
-    def from_proto(cls, config_proto: LoggingConfigProto) -> "LoggingConfig":
+    def from_proto(cls, config_proto: LoggingConfigProto) -> Optional["LoggingConfig"]:
         proto_attr_name = cast(str, config_proto.WhichOneof("destination"))
+        if proto_attr_name is None:
+            return
+
         destination_class = _DestinationRegistry.classes_by_proto_attr_name[
             proto_attr_name
         ]

@@ -2,9 +2,10 @@
 from typing import Any, Callable, Dict, List, Optional, Sequence, Tuple, Union
 
 import pandas
+import pyarrow
 from tqdm import tqdm
 
-from feast import Entity, FeatureView, RepoConfig
+from feast import Entity, FeatureView, RepoConfig, FeatureService
 from feast.infra.offline_stores.offline_store import RetrievalJob
 from feast.infra.provider import Provider
 from feast.protos.feast.types.EntityKey_pb2 import EntityKey as EntityKeyProto
@@ -79,3 +80,11 @@ def online_read(
 
     def retrieve_saved_dataset(self, config: RepoConfig, dataset: SavedDataset):
         pass
+
+    def write_feature_service_logs(self, feature_service: FeatureService, logs: pyarrow.Table, config: RepoConfig,
+                                   registry: Registry):
+        pass
+
+    def retrieve_feature_service_logs(self, feature_service: FeatureService, from_: datetime, to: datetime,
+                                      config: RepoConfig, registry: Registry) -> RetrievalJob:
+        pass
@@ -1,3 +1,4 @@
+import os.path
 import shutil
 import tempfile
 import uuid
@@ -81,6 +82,8 @@ def teardown(self):
             f.close()
 
         for d in self.dirs:
+            if not os.path.exists(d):
+                continue
             shutil.rmtree(d)
 
 
@@ -159,6 +162,15 @@ def create_saved_dataset_destination(self) -> SavedDatasetFileStorage:
             s3_endpoint_override=f"http://{host}:{port}",
         )
 
+    def create_logged_features_destination(self) -> LoggingDestination:
+        port = self.minio.get_exposed_port("9000")
+        host = self.minio.get_container_host_ip()
+
+        return FileLoggingDestination(
+            path=f"s3://{self.bucket}/logged_features/{str(uuid.uuid4())}",
+            s3_endpoint_override=f"http://{host}:{port}",
+        )
+
     def get_prefixed_table_name(self, suffix: str) -> str:
         return f"{suffix}"