Skip to content

fix: Fix push sources and add docs / tests pushing via the python feature server #2561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 18 commits into from
Apr 19, 2022
Merged

fix: Fix push sources and add docs / tests pushing via the python feature server #2561

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
93b165e
bug: Fixing push API endpoint to include a way to specify whether the…
adchia Apr 17, 2022
ddba206
fix
adchia Apr 17, 2022
23c9989
prune out unneeded fields in push source
adchia Apr 18, 2022
315f2d8
prune out unneeded fields in push source
adchia Apr 18, 2022
ec3d5c2
prune out unneeded fields in push source
adchia Apr 18, 2022
de905af
fix comment
adchia Apr 18, 2022
e6df1c3
fix comment
adchia Apr 18, 2022
ffc7436
fix comment
adchia Apr 18, 2022
42f6e27
fix comment
adchia Apr 18, 2022
5b37bb6
fix generator
adchia Apr 18, 2022
cf39fc3
add data source creator teardown
adchia Apr 18, 2022
ea6aaed
add data source creator teardown
adchia Apr 18, 2022
22dc1a4
update push source to alpha
adchia Apr 18, 2022
47c1697
lint
adchia Apr 18, 2022
1e3e5ff
lint
adchia Apr 18, 2022
152686e
lint
adchia Apr 18, 2022
05bc6a6
lint
adchia Apr 18, 2022
3964921
lint
adchia Apr 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
prune out unneeded fields in push source 
Signed-off-by: Danny Chiao <danny@tecton.ai>
  • Loading branch information
@adchia
adchia committed Apr 18, 2022
commit 315f2d84259326e34be4d4e57f1f79fbe4e3c3ce
7 changes: 1 addition & 6 deletions sdk/python/feast/feature_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1209,13 +1209,8 @@ def push(
}

for fv in fvs_with_push_sources:
push_source = cast(PushSource, fv.stream_source)
# If the push source's timestamp field doesn't match the batch source's timestamp field, do the mapping
renamed_df = df
if len(push_source.timestamp_field) > 0:
renamed_df = df.rename(columns={push_source.timestamp_field: push_source.batch_source.timestamp_field})
self.write_to_online_store(
fv.name, renamed_df, allow_registry_cache=allow_registry_cache
fv.name, df, allow_registry_cache=allow_registry_cache
)

@log_exceptions_and_usage
Expand Down