Skip to content

ci: Use testcontainers to spin up DynamoDB instances for local integration tests #2531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 2 commits into from
Apr 13, 2022
Merged

ci: Use testcontainers to spin up DynamoDB instances for local integration tests #2531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac43168
feat: DynamoDBOnlineStoreCreator
TremaMiguel Apr 12, 2022
41a0cfc
fix: DynamoDBOnlineStoreCreator return endpoint_url and aws region
TremaMiguel Apr 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,7 @@ These tests create new temporary tables / datasets locally only, and they are cl

The services with containerized replacements currently implemented are:
- Datastore
- DynamoDB
- Redis

You can run `make test-python-integration-container` to run tests against the containerized versions of dependencies.
Expand Down
8 changes: 7 additions & 1 deletion sdk/python/tests/integration/feature_repos/repo_configuration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,9 @@
from tests.integration.feature_repos.universal.online_store.datastore import (
DatastoreOnlineStoreCreator,
)
from tests.integration.feature_repos.universal.online_store.dynamodb import (
DynamoDBOnlineStoreCreator,
)
from tests.integration.feature_repos.universal.online_store.redis import (
RedisOnlineStoreCreator,
)
Expand Down Expand Up @@ -130,7 +133,10 @@

if os.getenv("FEAST_LOCAL_ONLINE_CONTAINER", "False").lower() == "true":
replacements = {"datastore": DatastoreOnlineStoreCreator}
replacement_dicts = [(REDIS_CONFIG, RedisOnlineStoreCreator)]
replacement_dicts = [
(REDIS_CONFIG, RedisOnlineStoreCreator),
(DYNAMO_CONFIG, DynamoDBOnlineStoreCreator),
]
for c in FULL_REPO_CONFIGS:
if isinstance(c.online_store, dict):
for _replacement in replacement_dicts:
Expand Down
34 changes: 34 additions & 0 deletions sdk/python/tests/integration/feature_repos/universal/online_store/dynamodb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
from typing import Dict

from testcontainers.core.container import DockerContainer
from testcontainers.core.waiting_utils import wait_for_logs

from tests.integration.feature_repos.universal.online_store_creator import (
OnlineStoreCreator,
)


class DynamoDBOnlineStoreCreator(OnlineStoreCreator):
def __init__(self, project_name: str):
super().__init__(project_name)
self.container = DockerContainer(
"amazon/dynamodb-local:latest"
).with_exposed_ports("8000")

def create_online_store(self) -> Dict[str, str]:
self.container.start()
log_string_to_wait_for = (
"Initializing DynamoDB Local with the following configuration:"
)
wait_for_logs(
container=self.container, predicate=log_string_to_wait_for, timeout=5
)
exposed_port = self.container.get_exposed_port("8000")
return {
"type": "dynamodb",
"endpoint_url": f"http://localhost:{exposed_port}",
"region": "us-west-2",
}

def teardown(self):
self.container.stop()