Skip to content

fix: Fixed bug in passing config file params to snowflake python connector #2503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 3 commits into from
Apr 7, 2022
Merged

fix: Fixed bug in passing config file params to snowflake python connector #2503

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
94295a0
fixed bug in passing config file params to snowflake python connector
sfc-gh-madkins Apr 6, 2022
b071d72
removed .keys() bug
sfc-gh-madkins Apr 6, 2022
3d19ee6
fixed schema assignment error
sfc-gh-madkins Apr 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/python/feast/infra/offline_stores/snowflake.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ class SnowflakeOfflineStoreConfig(FeastConfigBaseModel):
database: Optional[str] = None
""" Snowflake database name """

schema_: Optional[str] = Field("PUBLIC", alias="schema")
schema_: Optional[str] = Field(None, alias="schema")
""" Snowflake schema name """

class Config:
Expand Down
9 changes: 8 additions & 1 deletion sdk/python/feast/infra/utils/snowflake_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,13 +53,20 @@ def get_snowflake_conn(config, autocommit=True) -> SnowflakeConnection:
else:
kwargs = {}

if "schema" in kwargs:
kwargs["schema_"] = kwargs.pop("schema")

kwargs.update((k, v) for k, v in config_dict.items() if v is not None)
[
kwargs.update({k: '"' + v + '"'})
Comment thread
sfc-gh-madkins marked this conversation as resolved.
Outdated
for k, v in kwargs.items()
if k in ["role", "warehouse", "database", "schema_"]
]
kwargs["schema"] = kwargs.pop("schema_")

if "schema" in kwargs:
Comment thread
sfc-gh-madkins marked this conversation as resolved.
Outdated
kwargs["schema"] = kwargs.pop("schema_")
else:
kwargs["schema"] = '"PUBLIC"'

try:
conn = snowflake.connector.connect(
Expand Down