Skip to content

feat: Add Field class #2500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 3 commits into from
Apr 6, 2022
Merged

feat: Add Field class #2500

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0104782
Add Field class
felixwang9817 Apr 5, 2022
c59291b
Add __hash__
felixwang9817 Apr 6, 2022
995780a
Fix __hash__
felixwang9817 Apr 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix __hash__ 
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
  • Loading branch information
@felixwang9817
felixwang9817 committed Apr 6, 2022
commit 995780a4a155d4918ae2c3f94e713e976b6e2762
6 changes: 3 additions & 3 deletions sdk/python/feast/field.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,9 @@ def __eq__(self, other):
if self.name != other.name or self.dtype != other.dtype:
return False
return True

def __hash__(self):
return hash((id(self), self.name))
return hash((self.name, hash(self.dtype)))

def __lt__(self, other):
return self.name < other.name
Expand All @@ -72,7 +72,7 @@ def from_proto(cls, field_proto: FieldProto):
field_proto: FieldProto protobuf object
"""
return cls(name=field_proto.name, dtype=from_value_type(field_proto.value_type))

@classmethod
def from_feature(cls, feature: Feature):
"""
Expand Down
3 changes: 3 additions & 0 deletions sdk/python/feast/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,9 @@ def to_value_type(self) -> ValueTypeProto.Enum:
"""
raise NotImplementedError

def __hash__(self):
return hash(self.to_value_type())

def __eq__(self, other):
return self.to_value_type() == other.to_value_type()

Expand Down