ci: Use testcontainers to spin up redis and datastore instances - #2493
Merged
feast-ci-bot merged 12 commits intoApr 7, 2022
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2493 +/- ##
===========================================
+ Coverage 58.97% 84.32% +25.35%
===========================================
Files 129 134 +5
Lines 10987 11155 +168
===========================================
+ Hits 6480 9407 +2927
+ Misses 4507 1748 -2759
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
achals
force-pushed
the
achal/redis-test-container
branch
from
April 6, 2022 05:10
7575857 to
0f2e6f1
Compare
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
Signed-off-by: Achal Shah <achals@gmail.com>
achals
force-pushed
the
achal/redis-test-container
branch
from
April 6, 2022 22:00
a09cc74 to
9b37133
Compare
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Achal Shah achals@gmail.com
What this PR does / why we need it:
Running integration tests for contributors has been challenging since they don't always have access to GCP or AWS. This makes development or contributions harder than they need to be.
Additionally, there's some infrastructure that's needed to run tests locally - such as redis. This shouldn't have to be installed by contributors explicitly if it's not necessary.
Which issue(s) this PR fixes:
Fixes #