Skip to content

fix: Request data api update #2488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 14 commits into from
Apr 5, 2022
Merged

fix: Request data api update #2488

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
7cea469
Update request data source
kevjumba Apr 4, 2022
7b7395c
Fix
kevjumba Apr 4, 2022
945e0f8
Fix
kevjumba Apr 4, 2022
19158f8
Fix
kevjumba Apr 4, 2022
b284d5f
Data source update
kevjumba Apr 5, 2022
c90a224
Data source
kevjumba Apr 5, 2022
a362e9f
Temp fix
kevjumba Apr 5, 2022
f3c9d7a
Fix
kevjumba Apr 5, 2022
b442599
Update internal var names
kevjumba Apr 5, 2022
af8e98f
Add test
kevjumba Apr 5, 2022
b28932d
Fix
kevjumba Apr 5, 2022
9ecf9c8
Fix
kevjumba Apr 5, 2022
61230c8
Fix
kevjumba Apr 5, 2022
340b98a
Fix
kevjumba Apr 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix 
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
  • Loading branch information
@kevjumba
kevjumba committed Apr 5, 2022
commit b28932d68b5cc09b2720edcad8709f90239ec20f
4 changes: 2 additions & 2 deletions sdk/python/feast/on_demand_feature_view.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,10 +195,10 @@ def to_proto(self) -> OnDemandFeatureViewProto:
)
for (
source_name,
source_request_sources,
request_sources,
) in self.source_request_sources.items():
sources[source_name] = OnDemandSource(
source_request_sources=source_request_sources.to_proto()
request_data_source=request_sources.to_proto()
)

spec = OnDemandFeatureViewSpec(
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/feast/request_feature_view.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ def to_proto(self) -> RequestFeatureViewProto:
"""
spec = RequestFeatureViewSpec(
name=self.name,
request_source=self.request_source.to_proto(),
request_data_source=self.request_source.to_proto(),
description=self.description,
tags=self.tags,
owner=self.owner,
Expand Down
9 changes: 5 additions & 4 deletions sdk/python/tests/unit/test_data_sources.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import pytest
from aiohttp import request

from feast import ValueType
from feast.data_source import PushSource
from feast.data_source import PushSource, RequestDataSource
from feast.infra.offline_stores.bigquery_source import BigQuerySource
import pytest

from feast.data_source import RequestDataSource

def test_push_with_batch():
push_source = PushSource(
Expand All @@ -22,9 +22,10 @@ def test_push_with_batch():
assert push_source.schema == push_source_unproto.schema
assert push_source.batch_source.name == push_source_unproto.batch_source.name


def test_request_data_source_deprecation():
with pytest.warns(DeprecationWarning):
request_data_source = RequestDataSource(
name="vals_to_add",
schema={"val_to_add": ValueType.INT64, "val_to_add_2": ValueType.INT64},
)
)