Skip to content

feat: Add Support for DynamodbOnlineStoreConfig endpoint_url parameter #2485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 8 commits into from
Apr 8, 2022
Merged

feat: Add Support for DynamodbOnlineStoreConfig endpoint_url parameter #2485

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
af305e5
feat: support dynamodb client and resource with endpoint_url
TremaMiguel Apr 4, 2022
2180e2c
fix: overwrite by partitionkey batchwrite operation
TremaMiguel Apr 4, 2022
02f8071
docs: how to configure local dynamodb
TremaMiguel Apr 4, 2022
76efcea
fix: DynamoDBonlineStore endpoint_url defaults to None
TremaMiguel Apr 4, 2022
0440598
docs: setup dummy aws credentials
TremaMiguel Apr 4, 2022
7d23380
test: DynamoDBOnlineStoreConfig endpoint_url configuration
TremaMiguel Apr 6, 2022
4b9fcc6
Merge branch 'master' into feat/dynamodb-endpoint-url
TremaMiguel Apr 6, 2022
77c9f13
feat: DynamoDBTable support endpoint_url
TremaMiguel Apr 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
docs: setup dummy aws credentials 
Signed-off-by: Miguel Trejo <armando.trejo.marrufo@gmail.com>
  • Loading branch information
@TremaMiguel
TremaMiguel committed Apr 4, 2022
commit 0440598922d111af932d2488ae28e4e37bc6a75f
12 changes: 11 additions & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,17 @@ To test across clouds, on top of setting up Redis, you also need GCP / AWS / Sno

**AWS**
1. TODO(adchia): flesh out setting up AWS login (or create helper script)
2. To avoid AWS fees `DynamoDBOnlineStore` can be tested locally if you deploy DynamoDB Locally on your Computer, for this setup a [Local DynamoDB on your Computer](https://docs.aws.amazon.com/amazondynamodb/latest/developerguide/DynamoDBLocal.DownloadingAndRunning.html)
2. To avoid AWS fees `DynamoDBOnlineStore` can be tested locally if you deploy DynamoDB Locally on your Computer, for this

A. Setup a [Local DynamoDB on your Computer](https://docs.aws.amazon.com/amazondynamodb/latest/developerguide/DynamoDBLocal.DownloadingAndRunning.html).

B. Setup dummy AWS Credentials and `us-west-2` as region. (Optional: Only if testing the `DynamoDBOnlineStore`)

```txt
export AWS_ACCESS_KEY_ID: 'DUMMYIDEXAMPLE'
export AWS_SECRET_ACCESS_KEY: 'DUMMYEXAMPLEKEY'
export AWS_DEFAULT_REGION: 'us-west-2'
```
3. Modify `RedshiftDataSourceCreator` to use your credentials

**Snowflake**
Expand Down
4 changes: 2 additions & 2 deletions sdk/python/feast/infra/online_stores/dynamodb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
from typing import Any, Callable, Dict, List, Optional, Sequence, Tuple

from pydantic import StrictStr
from pydantic.typing import Literal
from pydantic.typing import Literal, Optional

from feast import Entity, FeatureView, utils
from feast.infra.infra_object import DYNAMODB_INFRA_OBJECT_CLASS_TYPE, InfraObject
Expand Down Expand Up @@ -53,7 +53,7 @@ class DynamoDBOnlineStoreConfig(FeastConfigBaseModel):
batch_size: int = 40
"""Number of items to retrieve in a DynamoDB BatchGetItem call."""

endpoint_url: str = None
endpoint_url: Optional[str] = None
"""DynamoDB local development endpoint Url, i.e. http://localhost:8000"""

region: StrictStr
Expand Down