Skip to content

fix: Add spark to lambda dockerfile #2480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 13 commits into from
Apr 4, 2022
Merged

fix: Add spark to lambda dockerfile #2480

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
92caab0
add spark to lambda dockerfile
achals Apr 2, 2022
4aef576
add *args
achals Apr 2, 2022
cba63fb
Add *args
felixwang9817 Apr 2, 2022
01a5680
Pin protobuf==3.19.4
felixwang9817 Apr 2, 2022
e534b16
Remove *args
felixwang9817 Apr 2, 2022
886f450
Add a range
achals Apr 3, 2022
b8b94e1
Add a todo
achals Apr 4, 2022
47eb5a1
cleanup prints
achals Apr 4, 2022
4c0d78e
lock deps
achals Apr 4, 2022
997165e
lock deps correctly
achals Apr 4, 2022
992c3b8
fix lint
achals Apr 4, 2022
6badd47
fix lint take 2
achals Apr 4, 2022
dfe125e
Undo general updates
achals Apr 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove *args 
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
  • Loading branch information
@felixwang9817
felixwang9817 committed Apr 2, 2022
commit e534b161d3c2f37e66119e3f463ed0063fae0692
8 changes: 5 additions & 3 deletions sdk/python/feast/proto_json.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ def to_json_object(printer: _Printer, message: ProtoMessage) -> JsonObject:
return value

def from_json_object(
parser: _Parser, value: JsonObject, message: ProtoMessage, *args
parser: _Parser, value: JsonObject, message: ProtoMessage,
) -> None:
if value is None:
message.null_val = 0
Expand Down Expand Up @@ -140,10 +140,12 @@ def to_json_object(printer: _Printer, message: ProtoMessage) -> JsonObject:
return [printer._MessageToJsonObject(item) for item in message.val]

def from_json_object(
parser: _Parser, value: JsonObject, message: ProtoMessage, *args
parser: _Parser, value: JsonObject, message: ProtoMessage,
) -> None:
print("going to convert message")
Copy link
Copy Markdown
Collaborator

@felixwang9817 felixwang9817 Apr 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove print

Copy link
Copy Markdown
Member Author

@achals achals Apr 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

array = value if isinstance(value, list) else value["val"]
for item in array:
print(f"item: {item}")
parser.ConvertMessage(item, message.val.add())

_patch_proto_json_encoding(RepeatedValue, to_json_object, from_json_object)
Expand Down Expand Up @@ -181,7 +183,7 @@ def to_json_object(printer: _Printer, message: ProtoMessage) -> JsonObject:
return list(message.val)

def from_json_object(
parser: _Parser, value: JsonObject, message: ProtoMessage, *args
parser: _Parser, value: JsonObject, message: ProtoMessage,
) -> None:
array = value if isinstance(value, list) else value["val"]
message.val.extend(array)
Expand Down