Skip to content

fix: Remove date partition column field from datasources that don't s… #2478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 11 commits into from
Apr 4, 2022
Merged

fix: Remove date partition column field from datasources that don't s… #2478

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
33245bc
fix: Remove date partition column field from datasources that don't s…
achals Apr 1, 2022
319b073
remove for file sources as well
achals Apr 1, 2022
d3aef10
remove other references
achals Apr 1, 2022
462c210
remove other references
achals Apr 1, 2022
d655ada
reference to removal
achals Apr 1, 2022
ed96a2b
reference to removal
achals Apr 1, 2022
06f81ed
reorder
achals Apr 1, 2022
0b7e26e
remove more:
achals Apr 1, 2022
300f76b
docs
achals Apr 1, 2022
2da035e
comment
achals Apr 1, 2022
c2dbd7b
cr
achals Apr 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove other references 
Signed-off-by: Achal Shah <achals@gmail.com>
  • Loading branch information
@achals
achals committed Apr 4, 2022
commit 462c2106dd6ed87d7e31a4fa4f553f487f6d2c13
13 changes: 7 additions & 6 deletions sdk/python/feast/infra/offline_stores/bigquery_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,18 @@


class BigQuerySource(DataSource):
def __hash__(self):
return super().__hash__()

# Note: Python requires redefining hash in child classes that override __eq__
def __init__(
self,
event_timestamp_column: Optional[str] = "",
table: Optional[str] = None,
table_ref: Optional[str] = None,
created_timestamp_column: Optional[str] = "",
date_partition_column: Optional[str] = None,
field_mapping: Optional[Dict[str, str]] = None,
date_partition_column: Optional[str] = None,
query: Optional[str] = None,
name: Optional[str] = None,
description: Optional[str] = "",
Expand Down Expand Up @@ -63,7 +67,8 @@ def __init__(
if date_partition_column:
warnings.warn(
Comment thread
felixwang9817 marked this conversation as resolved.
Outdated
(
"The argument 'date_partition_column' is not supported for BigQuery sources."
"The argument 'date_partition_column' is not supported for BigQuery sources. "
"It will be removed in Feast 0.21+"
),
DeprecationWarning,
)
Expand Down Expand Up @@ -93,10 +98,6 @@ def __init__(
owner=owner,
)

# Note: Python requires redefining hash in child classes that override __eq__
def __hash__(self):
return super().__hash__()

def __eq__(self, other):
if not isinstance(other, BigQuerySource):
raise TypeError(
Expand Down
1 change: 0 additions & 1 deletion sdk/python/tests/integration/feature_repos/universal/data_sources/file.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,6 @@ def create_data_source(
path=f"s3://{self.bucket}/{filename}",
event_timestamp_column=event_timestamp_column,
created_timestamp_column=created_timestamp_column,
date_partition_column="",
field_mapping=field_mapping or {"ts_1": "ts"},
s3_endpoint_override=f"http://{host}:{port}",
)
Expand Down
3 changes: 0 additions & 3 deletions sdk/python/tests/integration/registration/test_registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,6 @@ def test_modify_feature_views_success(test_registry):
path="file://feast/*",
event_timestamp_column="ts_col",
created_timestamp_column="timestamp",
date_partition_column="date_partition_col",
)

request_source = RequestDataSource(
Expand Down Expand Up @@ -363,7 +362,6 @@ def test_apply_feature_view_integration(test_registry):
path="file://feast/*",
event_timestamp_column="ts_col",
created_timestamp_column="timestamp",
date_partition_column="date_partition_col",
)

fv1 = FeatureView(
Expand Down Expand Up @@ -439,7 +437,6 @@ def test_apply_data_source(test_registry: Registry):
path="file://feast/*",
event_timestamp_column="ts_col",
created_timestamp_column="timestamp",
date_partition_column="date_partition_col",
)

fv1 = FeatureView(
Expand Down