Skip to content

fix: Update feature view APIs to prefer keyword args #2472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 3 commits into from
Mar 31, 2022
Merged

fix: Update feature view APIs to prefer keyword args #2472

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d2166e1
fix: Update feature view APIs to prefer keyword args
achals Mar 30, 2022
c27cf09
cr
achals Mar 31, 2022
e5b86be
fix tests
achals Mar 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
cr 
Signed-off-by: Achal Shah <achals@gmail.com>
  • Loading branch information
@achals
achals committed Mar 31, 2022
commit c27cf09742a21471b0a5e5b5e1bab0ed09d992cd
2 changes: 1 addition & 1 deletion sdk/python/feast/feature_view.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ def __init__(
)
if len(args) > len(positional_attributes):
raise ValueError(
f"Only {', '.join(positional_attributes)} are allowed positional args when defining "
f"Only {', '.join(positional_attributes)} are allowed as positional args when defining "
f"feature views, for backwards compatibility."
)
if len(args) >= 1:
Expand Down