Skip to content

fix: Make name a keyword arg for the Entity class #2467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 3 commits into from
Mar 30, 2022
Merged

fix: Make name a keyword arg for the Entity class #2467

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cab859b
fix: Make name a kwarg for Entity
achals Mar 30, 2022
87fb759
merge
achals Mar 30, 2022
3c3b33e
update test
achals Mar 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
update test 
Signed-off-by: Achal Shah <achals@gmail.com>
  • Loading branch information
@achals
achals committed Mar 30, 2022
commit 3c3b33efdbeaccd36260204798c63775f33ec918
4 changes: 1 addition & 3 deletions sdk/python/tests/unit/test_entity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,7 @@ def test_name_not_specified():


def test_multiple_args():
assertpy.assert_that(lambda: Entity("a", "b", value_type=ValueType.STRING)).raises(
ValueError
)
assertpy.assert_that(lambda: Entity("a", ValueType.STRING)).raises(ValueError)


def test_name_keyword(recwarn):
Expand Down