Skip to content

fix: Preserve ordering of features in _get_column_names #2457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 5 commits into from
Apr 4, 2022
Merged

fix: Preserve ordering of features in _get_column_names #2457

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ae19b2f
Preserve ordering of features in _get_column_names
mavysavydav Mar 26, 2022
2e179d0
Correction + unit test
mavysavydav Mar 31, 2022
d50151a
lint corrections
mavysavydav Mar 31, 2022
e49b324
correction
mavysavydav Mar 31, 2022
363113d
my 'make lint' seems to work differently than the ones in the PR test…
mavysavydav Mar 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lint corrections 
Signed-off-by: David Y Liu <davidyliuliu@gmail.com>
  • Loading branch information
@mavysavydav
mavysavydav committed Mar 31, 2022
commit d50151aeb6e4d455b59ae59f71444666e0920501
2 changes: 1 addition & 1 deletion sdk/python/feast/go_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,10 @@
from subprocess import Popen
from typing import Any, Dict, List, Optional, Union

import grpc
from tenacity import retry, stop_after_attempt, stop_after_delay, wait_exponential

import feast
import grpc
from feast.errors import FeatureNameCollisionError, InvalidFeaturesParameterType
from feast.feature_service import FeatureService
from feast.flags_helper import is_test
Expand Down
11 changes: 7 additions & 4 deletions sdk/python/feast/infra/provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,10 +290,13 @@ def _get_column_names(

# We need to exclude join keys and timestamp columns from the list of features, after they are mapped to
# their final column names via the `field_mapping` field of the source.
feature_names = [name for name in feature_names
if name not in join_keys
and name != event_timestamp_column
and name != created_timestamp_column]
feature_names = [
name
for name in feature_names
if name not in join_keys
and name != event_timestamp_column
and name != created_timestamp_column
]
return (
join_keys,
feature_names,
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/feast/transformation_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@
import sys
from concurrent import futures

import grpc
import pyarrow as pa
from grpc_reflection.v1alpha import reflection

import grpc
from feast.errors import OnDemandFeatureViewNotFoundException
from feast.feature_store import FeatureStore
from feast.protos.feast.serving.TransformationService_pb2 import (
Expand Down