Skip to content

chore: Rename inputs parameter to sources for on demand feature views #2442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 7 commits into from
Mar 29, 2022
Merged

chore: Rename inputs parameter to sources for on demand feature views #2442

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7c6221d
Rename `inputs` parameter to `sources` for odfv
felixwang9817 Mar 23, 2022
e47449c
Address CR comments
felixwang9817 Mar 25, 2022
d966787
Fix Go references to ODFV proto
felixwang9817 Mar 25, 2022
dbafedd
Fix tests
felixwang9817 Mar 26, 2022
05b393e
Fix Java
felixwang9817 Mar 26, 2022
1b9d808
Fix Java again
felixwang9817 Mar 26, 2022
18ca377
Fix Python integration tests
felixwang9817 Mar 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix tests 
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
  • Loading branch information
@felixwang9817
felixwang9817 committed Mar 28, 2022
commit dbafeddf498bb0a18ee019bc8d0804f3937b5512
8 changes: 4 additions & 4 deletions sdk/python/tests/integration/feature_repos/universal/feature_views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ def conv_rate_plus_100(features_df: pd.DataFrame) -> pd.DataFrame:


def conv_rate_plus_100_feature_view(
inputs: Dict[str, Union[RequestDataSource, FeatureView]],
sources: Dict[str, Union[RequestDataSource, FeatureView]],
infer_features: bool = False,
features: Optional[List[Feature]] = None,
) -> OnDemandFeatureView:
Expand All @@ -63,7 +63,7 @@ def conv_rate_plus_100_feature_view(
]
return OnDemandFeatureView(
name=conv_rate_plus_100.__name__,
inputs=inputs,
sources=sources,
features=[] if infer_features else _features,
udf=conv_rate_plus_100,
)
Expand All @@ -87,7 +87,7 @@ def similarity(features_df: pd.DataFrame) -> pd.DataFrame:


def similarity_feature_view(
inputs: Dict[str, Union[RequestDataSource, FeatureView]],
sources: Dict[str, Union[RequestDataSource, FeatureView]],
infer_features: bool = False,
features: Optional[List[Feature]] = None,
) -> OnDemandFeatureView:
Expand All @@ -97,7 +97,7 @@ def similarity_feature_view(
]
return OnDemandFeatureView(
name=similarity.__name__,
inputs=inputs,
sources=sources,
features=[] if infer_features else _features,
udf=similarity,
)
Expand Down
12 changes: 6 additions & 6 deletions sdk/python/tests/integration/registration/test_inference.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ def test_on_demand_features_type_inference():
)

@on_demand_feature_view(
inputs={"date_request": date_request},
sources={"date_request": date_request},
features=[
Feature("output", ValueType.UNIX_TIMESTAMP),
Feature("string_output", ValueType.STRING),
Expand All @@ -184,7 +184,7 @@ def test_view(features_df: pd.DataFrame) -> pd.DataFrame:
test_view.infer_features()

@on_demand_feature_view(
inputs={"date_request": date_request},
sources={"date_request": date_request},
features=[
Feature("output", ValueType.UNIX_TIMESTAMP),
Feature("object_output", ValueType.STRING),
Expand All @@ -200,7 +200,7 @@ def invalid_test_view(features_df: pd.DataFrame) -> pd.DataFrame:
invalid_test_view.infer_features()

@on_demand_feature_view(
inputs={"date_request": date_request},
sources={"date_request": date_request},
features=[
Feature("output", ValueType.UNIX_TIMESTAMP),
Feature("missing", ValueType.STRING),
Expand All @@ -222,7 +222,7 @@ def test_datasource_inference():
)

@on_demand_feature_view(
inputs={"date_request": date_request},
sources={"date_request": date_request},
features=[
Feature("output", ValueType.UNIX_TIMESTAMP),
Feature("string_output", ValueType.STRING),
Expand All @@ -237,7 +237,7 @@ def test_view(features_df: pd.DataFrame) -> pd.DataFrame:
test_view.infer_features()

@on_demand_feature_view(
inputs={"date_request": date_request},
sources={"date_request": date_request},
features=[
Feature("output", ValueType.UNIX_TIMESTAMP),
Feature("object_output", ValueType.STRING),
Expand All @@ -253,7 +253,7 @@ def invalid_test_view(features_df: pd.DataFrame) -> pd.DataFrame:
invalid_test_view.infer_features()

@on_demand_feature_view(
inputs={"date_request": date_request},
sources={"date_request": date_request},
features=[
Feature("output", ValueType.UNIX_TIMESTAMP),
Feature("missing", ValueType.STRING),
Expand Down
4 changes: 2 additions & 2 deletions sdk/python/tests/integration/registration/test_registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ def test_modify_feature_views_success(test_registry):
Feature(name="odfv1_my_feature_1", dtype=ValueType.STRING),
Feature(name="odfv1_my_feature_2", dtype=ValueType.INT32),
],
inputs={"request_source": request_source},
sources={"request_source": request_source},
)
def odfv1(feature_df: pd.DataFrame) -> pd.DataFrame:
data = pd.DataFrame()
Expand All @@ -284,7 +284,7 @@ def odfv1(feature_df: pd.DataFrame) -> pd.DataFrame:
Feature(name="odfv1_my_feature_1", dtype=ValueType.FLOAT),
Feature(name="odfv1_my_feature_2", dtype=ValueType.INT32),
],
inputs={"request_source": request_source},
sources={"request_source": request_source},
)
def odfv1(feature_df: pd.DataFrame) -> pd.DataFrame:
data = pd.DataFrame()
Expand Down