ci: Pin setup-gcloud actions to v0 instead of master - #2434
Merged
Conversation
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #2434 +/- ##
=======================================
Coverage 83.42% 83.42%
=======================================
Files 122 122
Lines 10704 10704
=======================================
Hits 8930 8930
Misses 1774 1774
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
felixwang9817
added a commit
that referenced
this pull request
Apr 6, 2022
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Felix Wang wangfelix98@gmail.com
What this PR does / why we need it: Tests on master were recently failing due to the
setup-gcloudaction being pinned tomaster. In the near future,masterwill be renamed tomain; moreover, we should not be pinning tomasteranyways. This PR pins thesetup-gcloudaction tov0instead.Which issue(s) this PR fixes:
Fixes #