Skip to content

fix: Add PushSource proto and Python class #2428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 6 commits into from
Mar 22, 2022
Merged

fix: Add PushSource proto and Python class #2428

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d4d0df3
fix: Add PushSource proto and Python class
achals Mar 21, 2022
b229f91
tests
achals Mar 21, 2022
1413a9b
remove pdb
achals Mar 21, 2022
ad38165
cr
achals Mar 22, 2022
c271783
cr
achals Mar 22, 2022
9182d3d
cr
achals Mar 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
cr 
Signed-off-by: Achal Shah <achals@gmail.com>
  • Loading branch information
@achals
achals committed Mar 22, 2022
commit 9182d3d6391e775c0e6f4736fa5be41199a88db5
4 changes: 2 additions & 2 deletions sdk/python/feast/data_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,8 +560,8 @@ def get_table_column_names_and_types(
def from_proto(data_source: DataSourceProto):
schema_pb = data_source.push_options.schema
schema = {}
for key in schema_pb.keys():
schema[key] = ValueType(schema_pb.get(key))
for key, value in schema_pb.items():
schema[key] = value

batch_source = None
if data_source.push_options.HasField("batch_source"):
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/tests/unit/test_data_sources.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,4 @@ def test_push_with_batch():

assert push_source.name == push_source_unproto.name
assert push_source.schema == push_source_unproto.schema
assert push_source.batch_source == push_source_unproto.batch_source
assert push_source.batch_source.name == push_source_unproto.batch_source.name